Commit 9fdc6d91 authored by mattm@chromium.org's avatar mattm@chromium.org

Remove obsolete NSS version checks.

BUG=none

Review URL: https://codereview.chromium.org/141503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245646 0039d316-1c4b-4281-b951-d872f2087c98
parent 92377998
...@@ -173,10 +173,7 @@ TEST_F(PolicyCertVerifierTest, VerifyTrustedCert) { ...@@ -173,10 +173,7 @@ TEST_F(PolicyCertVerifierTest, VerifyTrustedCert) {
} }
TEST_F(PolicyCertVerifierTest, VerifyUsingAdditionalTrustAnchor) { TEST_F(PolicyCertVerifierTest, VerifyUsingAdditionalTrustAnchor) {
if (!SupportsAdditionalTrustAnchors()) { ASSERT_TRUE(SupportsAdditionalTrustAnchors());
LOG(INFO) << "Test skipped on this platform. NSS >= 3.14.2 required.";
return;
}
// |test_server_cert_| is untrusted, so Verify() fails. // |test_server_cert_| is untrusted, so Verify() fails.
{ {
......
...@@ -33,17 +33,6 @@ ...@@ -33,17 +33,6 @@
#include "net/cert/x509_util_ios.h" #include "net/cert/x509_util_ios.h"
#endif // defined(OS_IOS) #endif // defined(OS_IOS)
#define NSS_VERSION_NUM (NSS_VMAJOR * 10000 + NSS_VMINOR * 100 + NSS_VPATCH)
#if NSS_VERSION_NUM < 31305
// Added in NSS 3.13.5.
#define SEC_ERROR_CERT_SIGNATURE_ALGORITHM_DISABLED -8016
#endif
#if NSS_VERSION_NUM < 31402
// Added in NSS 3.14.2.
#define cert_pi_useOnlyTrustAnchors static_cast<CERTValParamInType>(14)
#endif
namespace net { namespace net {
namespace { namespace {
...@@ -744,8 +733,7 @@ CertVerifyProcNSS::CertVerifyProcNSS() {} ...@@ -744,8 +733,7 @@ CertVerifyProcNSS::CertVerifyProcNSS() {}
CertVerifyProcNSS::~CertVerifyProcNSS() {} CertVerifyProcNSS::~CertVerifyProcNSS() {}
bool CertVerifyProcNSS::SupportsAdditionalTrustAnchors() const { bool CertVerifyProcNSS::SupportsAdditionalTrustAnchors() const {
// This requires APIs introduced in 3.14.2. return true;
return NSS_VersionCheck("3.14.2");
} }
int CertVerifyProcNSS::VerifyInternal( int CertVerifyProcNSS::VerifyInternal(
...@@ -801,7 +789,7 @@ int CertVerifyProcNSS::VerifyInternal( ...@@ -801,7 +789,7 @@ int CertVerifyProcNSS::VerifyInternal(
verify_result->cert_status |= CERT_STATUS_REV_CHECKING_ENABLED; verify_result->cert_status |= CERT_STATUS_REV_CHECKING_ENABLED;
ScopedCERTCertList trust_anchors; ScopedCERTCertList trust_anchors;
if (SupportsAdditionalTrustAnchors() && !additional_trust_anchors.empty()) { if (!additional_trust_anchors.empty()) {
trust_anchors.reset( trust_anchors.reset(
CertificateListToCERTCertList(additional_trust_anchors)); CertificateListToCERTCertList(additional_trust_anchors));
} }
......
...@@ -591,13 +591,6 @@ TEST_F(CertDatabaseNSSTest, ImportServerCert_SelfSigned) { ...@@ -591,13 +591,6 @@ TEST_F(CertDatabaseNSSTest, ImportServerCert_SelfSigned) {
} }
TEST_F(CertDatabaseNSSTest, ImportServerCert_SelfSigned_Trusted) { TEST_F(CertDatabaseNSSTest, ImportServerCert_SelfSigned_Trusted) {
// When using CERT_PKIXVerifyCert (which we do), server trust only works from
// 3.13.4 onwards. See https://bugzilla.mozilla.org/show_bug.cgi?id=647364.
if (!NSS_VersionCheck("3.13.4")) {
LOG(INFO) << "test skipped on NSS < 3.13.4";
return;
}
CertificateList certs; CertificateList certs;
ASSERT_TRUE(ReadCertIntoList("punycodetest.der", &certs)); ASSERT_TRUE(ReadCertIntoList("punycodetest.der", &certs));
...@@ -666,12 +659,6 @@ TEST_F(CertDatabaseNSSTest, ImportCaAndServerCert) { ...@@ -666,12 +659,6 @@ TEST_F(CertDatabaseNSSTest, ImportCaAndServerCert) {
} }
TEST_F(CertDatabaseNSSTest, ImportCaAndServerCert_DistrustServer) { TEST_F(CertDatabaseNSSTest, ImportCaAndServerCert_DistrustServer) {
// Explicit distrust only works starting in NSS 3.13.
if (!NSS_VersionCheck("3.13")) {
LOG(INFO) << "test skipped on NSS < 3.13";
return;
}
CertificateList ca_certs = CreateCertificateListFromFile( CertificateList ca_certs = CreateCertificateListFromFile(
GetTestCertsDirectory(), "root_ca_cert.pem", GetTestCertsDirectory(), "root_ca_cert.pem",
X509Certificate::FORMAT_AUTO); X509Certificate::FORMAT_AUTO);
...@@ -760,12 +747,6 @@ TEST_F(CertDatabaseNSSTest, TrustIntermediateCa) { ...@@ -760,12 +747,6 @@ TEST_F(CertDatabaseNSSTest, TrustIntermediateCa) {
EXPECT_EQ(OK, error); EXPECT_EQ(OK, error);
EXPECT_EQ(0U, verify_result.cert_status); EXPECT_EQ(0U, verify_result.cert_status);
// Explicit distrust only works starting in NSS 3.13.
if (!NSS_VersionCheck("3.13")) {
LOG(INFO) << "test partially skipped on NSS < 3.13";
return;
}
// Trust the root cert and distrust the intermediate. // Trust the root cert and distrust the intermediate.
EXPECT_TRUE(cert_db_->SetCertTrust( EXPECT_TRUE(cert_db_->SetCertTrust(
ca_certs[0].get(), CA_CERT, NSSCertDatabase::TRUSTED_SSL)); ca_certs[0].get(), CA_CERT, NSSCertDatabase::TRUSTED_SSL));
...@@ -929,12 +910,6 @@ TEST_F(CertDatabaseNSSTest, TrustIntermediateCa3) { ...@@ -929,12 +910,6 @@ TEST_F(CertDatabaseNSSTest, TrustIntermediateCa3) {
} }
TEST_F(CertDatabaseNSSTest, TrustIntermediateCa4) { TEST_F(CertDatabaseNSSTest, TrustIntermediateCa4) {
// Explicit distrust only works starting in NSS 3.13.
if (!NSS_VersionCheck("3.13")) {
LOG(INFO) << "test skipped on NSS < 3.13";
return;
}
NSSCertDatabase::ImportCertFailureList failed; NSSCertDatabase::ImportCertFailureList failed;
CertificateList ca_certs = CreateCertificateListFromFile( CertificateList ca_certs = CreateCertificateListFromFile(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment