Rename CreateFromDer() to Create().

This is consistent with ParsedCertificate::Create() and
SignatureAlgorithm::Create().

Review-Url: https://codereview.chromium.org/2353333003
Cr-Commit-Position: refs/heads/master@{#420549}

net/cert/internal/name_constraints.cc

@@ -300,7 +300,7 @@ GeneralNames::GeneralNames() {}
 GeneralNames::~GeneralNames() {}
 
 // static
-std::unique_ptr<GeneralNames> GeneralNames::CreateFromDer(
+std::unique_ptr<GeneralNames> GeneralNames::Create(
     const der::Input& general_names_tlv) {
   // RFC 5280 section 4.2.1.6:
   // GeneralNames ::= SEQUENCE SIZE (1..MAX) OF GeneralName
@@ -332,7 +332,7 @@ std::unique_ptr<GeneralNames> GeneralNames::CreateFromDer(
 NameConstraints::~NameConstraints() {}
 
 // static
-std::unique_ptr<NameConstraints> NameConstraints::CreateFromDer(
+std::unique_ptr<NameConstraints> NameConstraints::Create(
     const der::Input& extension_value,
     bool is_critical) {
   std::unique_ptr<NameConstraints> name_constraints(new NameConstraints());

net/cert/internal/name_constraints.h

@@ -48,7 +48,7 @@ struct NET_EXPORT GeneralNames {
 
   // Create a GeneralNames object representing the DER-encoded
   // |general_names_tlv|.
-  static std::unique_ptr<GeneralNames> CreateFromDer(
+  static std::unique_ptr<GeneralNames> Create(
       const der::Input& general_names_tlv);
 
   // ASCII hostnames.
@@ -84,7 +84,7 @@ class NET_EXPORT NameConstraints {
   // the OCTET STRING tag). |is_critical| should be true if the extension was
   // marked critical. Returns nullptr if parsing the the extension failed.
   // The object lifetime is not bound to the lifetime of |extension_value| data.
-  static std::unique_ptr<NameConstraints> CreateFromDer(
+  static std::unique_ptr<NameConstraints> Create(
       const der::Input& extension_value,
       bool is_critical);
 

net/cert/internal/parse_certificate.h

@@ -85,7 +85,7 @@ struct NET_EXPORT ParseCertificateOptions {
 //
 // This contains the full (unverified) Tag-Length-Value for a SEQUENCE. No
 // guarantees are made regarding the value of this SEQUENCE.
-// This can be further parsed using SignatureValue::CreateFromDer().
+// This can be further parsed using SignatureValue::Create().
 //
 // The |out_signature_value| parameter corresponds with "signatureValue" from
 // RFC 5280:
@@ -183,7 +183,7 @@ struct NET_EXPORT ParsedTbsCertificate {
   // This contains the full (unverified) Tag-Length-Value for a SEQUENCE. No
   // guarantees are made regarding the value of this SEQUENCE.
   //
-  // This can be further parsed using SignatureValue::CreateFromDer().
+  // This can be further parsed using SignatureValue::Create().
   der::Input signature_algorithm_tlv;
 
   // Corresponds with "issuer" from RFC 5280:

net/cert/internal/parse_certificate_fuzzer.cc

@@ -61,7 +61,7 @@ void ParseCertificateForFuzzer(const der::Input& in) {
     if (FindExtension(KeyUsageOid(), &extensions, &extension))
       ignore_result(ParseKeyUsage(extension.value, &key_usage));
     if (FindExtension(SubjectAltNameOid(), &extensions, &extension))
-      GeneralNames::CreateFromDer(extension.value);
+      GeneralNames::Create(extension.value);
     if (FindExtension(CertificatePoliciesOid(), &extensions, &extension))
       ParseCertificatePoliciesExtension(extension.value, &policies);
     if (FindExtension(ExtKeyUsageOid(), &extensions, &extension))

net/cert/internal/parsed_certificate.cc

@@ -104,7 +104,7 @@ scoped_refptr<ParsedCertificate> ParsedCertificate::CreateInternal(
   }
 
   // Attempt to parse the signature algorithm contained in the Certificate.
-  // Do not give up on failure here, since SignatureAlgorithm::CreateFromDer
+  // Do not give up on failure here, since SignatureAlgorithm::Create
   // will fail on valid but unsupported signature algorithms.
   // TODO(mattm): should distinguish between unsupported algorithms and parsing
   // errors.
@@ -155,8 +155,8 @@ scoped_refptr<ParsedCertificate> ParsedCertificate::CreateInternal(
                          &result->subject_alt_names_extension_)) {
       // RFC 5280 section 4.2.1.6:
       // SubjectAltName ::= GeneralNames
-      result->subject_alt_names_ = GeneralNames::CreateFromDer(
-          result->subject_alt_names_extension_.value);
+      result->subject_alt_names_ =
+          GeneralNames::Create(result->subject_alt_names_extension_.value);
       if (!result->subject_alt_names_)
         return nullptr;
       // RFC 5280 section 4.1.2.6:
@@ -174,7 +174,7 @@ scoped_refptr<ParsedCertificate> ParsedCertificate::CreateInternal(
     if (ConsumeExtension(NameConstraintsOid(), &result->unparsed_extensions_,
                          &extension)) {
       result->name_constraints_ =
-          NameConstraints::CreateFromDer(extension.value, extension.critical);
+          NameConstraints::Create(extension.value, extension.critical);
       if (!result->name_constraints_)
         return nullptr;
     }

net/cert/x509_util.cc

@@ -159,7 +159,7 @@ bool ParseCertificateSandboxed(const base::StringPiece& certificate,
   auto iter = extensions.find(SubjectAltNameOid());
   if (iter != extensions.end()) {
     std::unique_ptr<GeneralNames> subject_alt_names =
-        GeneralNames::CreateFromDer(iter->second.value);
+        GeneralNames::Create(iter->second.value);
     if (subject_alt_names) {
       *dns_names = subject_alt_names->dns_names;
       for (const auto& ip : subject_alt_names->ip_addresses)