Commit 9ff46400 authored by Mansi Awasthi's avatar Mansi Awasthi Committed by Commit Bot

Remove unnecessary kEditable state from PDF text field AXNode

Bug: 1030242
Change-Id: I84a837b95eb48f05c144bf47d557bbcf303fa78c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135101
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756415}
parent 20ab05ad
...@@ -977,8 +977,6 @@ ui::AXNodeData* PdfAccessibilityTree::CreateTextFieldNode( ...@@ -977,8 +977,6 @@ ui::AXNodeData* PdfAccessibilityTree::CreateTextFieldNode(
text_field_node->AddState(ax::mojom::State::kRequired); text_field_node->AddState(ax::mojom::State::kRequired);
if (text_field.is_password) if (text_field.is_password)
text_field_node->AddState(ax::mojom::State::kProtected); text_field_node->AddState(ax::mojom::State::kProtected);
if (!text_field.is_read_only)
text_field_node->AddState(ax::mojom::State::kEditable);
text_field_node->relative_bounds.bounds = text_field_node->relative_bounds.bounds =
PpFloatRectToGfxRectF(text_field.bounds); PpFloatRectToGfxRectF(text_field.bounds);
return text_field_node; return text_field_node;
......
...@@ -630,7 +630,6 @@ TEST_F(PdfAccessibilityTreeTest, TestTextFieldNodeCreation) { ...@@ -630,7 +630,6 @@ TEST_F(PdfAccessibilityTreeTest, TestTextFieldNodeCreation) {
ax::mojom::StringAttribute::kValue)); ax::mojom::StringAttribute::kValue));
EXPECT_FALSE(text_field_node->data().HasState(ax::mojom::State::kRequired)); EXPECT_FALSE(text_field_node->data().HasState(ax::mojom::State::kRequired));
EXPECT_FALSE(text_field_node->data().HasState(ax::mojom::State::kProtected)); EXPECT_FALSE(text_field_node->data().HasState(ax::mojom::State::kProtected));
EXPECT_TRUE(text_field_node->data().HasState(ax::mojom::State::kEditable));
EXPECT_NE(ax::mojom::Restriction::kReadOnly, EXPECT_NE(ax::mojom::Restriction::kReadOnly,
text_field_node->data().GetRestriction()); text_field_node->data().GetRestriction());
EXPECT_EQ(gfx::RectF(1.0f, 1.0f, 5.0f, 6.0f), EXPECT_EQ(gfx::RectF(1.0f, 1.0f, 5.0f, 6.0f),
...@@ -646,7 +645,6 @@ TEST_F(PdfAccessibilityTreeTest, TestTextFieldNodeCreation) { ...@@ -646,7 +645,6 @@ TEST_F(PdfAccessibilityTreeTest, TestTextFieldNodeCreation) {
ax::mojom::StringAttribute::kValue)); ax::mojom::StringAttribute::kValue));
EXPECT_TRUE(text_field_node->data().HasState(ax::mojom::State::kRequired)); EXPECT_TRUE(text_field_node->data().HasState(ax::mojom::State::kRequired));
EXPECT_TRUE(text_field_node->data().HasState(ax::mojom::State::kProtected)); EXPECT_TRUE(text_field_node->data().HasState(ax::mojom::State::kProtected));
EXPECT_FALSE(text_field_node->data().HasState(ax::mojom::State::kEditable));
EXPECT_EQ(ax::mojom::Restriction::kReadOnly, EXPECT_EQ(ax::mojom::Restriction::kReadOnly,
text_field_node->data().GetRestriction()); text_field_node->data().GetRestriction());
EXPECT_EQ(gfx::RectF(1.0f, 10.0f, 5.0f, 6.0f), EXPECT_EQ(gfx::RectF(1.0f, 10.0f, 5.0f, 6.0f),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment