Commit a03c08b1 authored by Varun Khaneja's avatar Varun Khaneja Committed by Commit Bot

Send a ClientSafeBrowsingReportRequest for the Billing interstitial.

Server side change: http://cl/219735922

Tested by checking the "ClientSafeBrowsingReportRequests"
tab on chrome://safe-browsing

Bug: 867518,901215
Change-Id: I04356eb38f7b2306c5b74baed6ca3f73969a3dbd
Reviewed-on: https://chromium-review.googlesource.com/c/1313881Reviewed-by: default avatarDaniel Rubery <drubery@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605884}
parent 9eae3e2b
...@@ -379,11 +379,12 @@ void BaseBlockingPage::set_sb_error_ui( ...@@ -379,11 +379,12 @@ void BaseBlockingPage::set_sb_error_ui(
// static // static
bool BaseBlockingPage::ShouldReportThreatDetails(SBThreatType threat_type) { bool BaseBlockingPage::ShouldReportThreatDetails(SBThreatType threat_type) {
return threat_type == SB_THREAT_TYPE_URL_PHISHING || return threat_type == SB_THREAT_TYPE_BILLING ||
threat_type == SB_THREAT_TYPE_URL_MALWARE || threat_type == SB_THREAT_TYPE_URL_CLIENT_SIDE_MALWARE ||
threat_type == SB_THREAT_TYPE_URL_UNWANTED ||
threat_type == SB_THREAT_TYPE_URL_CLIENT_SIDE_PHISHING || threat_type == SB_THREAT_TYPE_URL_CLIENT_SIDE_PHISHING ||
threat_type == SB_THREAT_TYPE_URL_CLIENT_SIDE_MALWARE; threat_type == SB_THREAT_TYPE_URL_MALWARE ||
threat_type == SB_THREAT_TYPE_URL_PHISHING ||
threat_type == SB_THREAT_TYPE_URL_UNWANTED;
} }
} // namespace safe_browsing } // namespace safe_browsing
...@@ -99,6 +99,8 @@ ClientSafeBrowsingReportRequest::ReportType GetReportTypeFromSBThreatType( ...@@ -99,6 +99,8 @@ ClientSafeBrowsingReportRequest::ReportType GetReportTypeFromSBThreatType(
return ClientSafeBrowsingReportRequest::URL_PASSWORD_PROTECTION_PHISHING; return ClientSafeBrowsingReportRequest::URL_PASSWORD_PROTECTION_PHISHING;
case SB_THREAT_TYPE_SUSPICIOUS_SITE: case SB_THREAT_TYPE_SUSPICIOUS_SITE:
return ClientSafeBrowsingReportRequest::URL_SUSPICIOUS; return ClientSafeBrowsingReportRequest::URL_SUSPICIOUS;
case SB_THREAT_TYPE_BILLING:
return ClientSafeBrowsingReportRequest::BILLING;
default: // Gated by SafeBrowsingBlockingPage::ShouldReportThreatDetails. default: // Gated by SafeBrowsingBlockingPage::ShouldReportThreatDetails.
NOTREACHED() << "We should not send report for threat type " NOTREACHED() << "We should not send report for threat type "
<< threat_type; << threat_type;
......
...@@ -1063,6 +1063,7 @@ message ClientSafeBrowsingReportRequest { ...@@ -1063,6 +1063,7 @@ message ClientSafeBrowsingReportRequest {
DANGEROUS_DOWNLOAD_OPENED = 13; DANGEROUS_DOWNLOAD_OPENED = 13;
AD_SAMPLE = 14; AD_SAMPLE = 14;
URL_SUSPICIOUS = 15; URL_SUSPICIOUS = 15;
BILLING = 16;
} }
message HTTPHeader { message HTTPHeader {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment