Commit a0447ff9 authored by rnk@chromium.org's avatar rnk@chromium.org

Add memcheck annotation and remove suppression.

This is really re-landing 112937 and attempting to avoid a warning from the
Linux builder.

R=jar@chromium.org
BUG=106326
TEST=needs to run on the CQ


Review URL: http://codereview.chromium.org/8796006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112944 0039d316-1c4b-4281-b951-d872f2087c98
parent bf2120b3
...@@ -9,6 +9,7 @@ ...@@ -9,6 +9,7 @@
#include "base/format_macros.h" #include "base/format_macros.h"
#include "base/message_loop.h" #include "base/message_loop.h"
#include "base/stringprintf.h" #include "base/stringprintf.h"
#include "base/third_party/valgrind/memcheck.h"
#include "base/threading/thread_restrictions.h" #include "base/threading/thread_restrictions.h"
#include "build/build_config.h" #include "build/build_config.h"
#include "base/port.h" #include "base/port.h"
...@@ -219,6 +220,8 @@ ThreadData::~ThreadData() {} ...@@ -219,6 +220,8 @@ ThreadData::~ThreadData() {}
void ThreadData::PushToHeadOfList() { void ThreadData::PushToHeadOfList() {
// Toss in a hint of randomness (atop the uniniitalized value). // Toss in a hint of randomness (atop the uniniitalized value).
(void)VALGRIND_MAKE_MEM_DEFINED_IF_ADDRESSABLE(random_number_,
sizeof(random_number_));
random_number_ += static_cast<int32>(this - static_cast<ThreadData*>(0)); random_number_ += static_cast<int32>(this - static_cast<ThreadData*>(0));
random_number_ ^= (Now() - TrackedTime()).InMilliseconds(); random_number_ ^= (Now() - TrackedTime()).InMilliseconds();
......
...@@ -5322,13 +5322,6 @@ ...@@ -5322,13 +5322,6 @@
fun:_ZN7WebCoreL21executeInsertFragmentEPNS_5FrameEN3WTF10PassRefPtrINS_16DocumentFragmentEEE fun:_ZN7WebCoreL21executeInsertFragmentEPNS_5FrameEN3WTF10PassRefPtrINS_16DocumentFragmentEEE
fun:_ZN7WebCoreL17executeInsertHTMLEPNS_5FrameEPNS_5EventENS_19EditorCommandSourceERKN3WTF6StringE fun:_ZN7WebCoreL17executeInsertHTMLEPNS_5FrameEPNS_5EventENS_19EditorCommandSourceERKN3WTF6StringE
} }
{
bug_106326
Memcheck:Uninitialized
fun:_ZN15tracked_objects9DeathData11RecordDeathEiii
fun:_ZN15tracked_objects10ThreadData11TallyADeathERKNS_6BirthsEii
fun:_ZN15tracked_objects10ThreadData31TallyRunOnNamedThreadIfTrackingERKN4base12TrackingInfoERKNS_11TrackedTimeES7_
}
{ {
bug_106331 bug_106331
Memcheck:Leak Memcheck:Leak
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment