Commit a0508bb3 authored by davidben@chromium.org's avatar davidben@chromium.org

Add tests for session cache and false start behavior.

False start should not disable the session cache, but if we never process the
server Finished message, the session cannot be resumed.

BUG=none

Review URL: https://codereview.chromium.org/301283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276815 0039d316-1c4b-4281-b951-d872f2087c98
parent 3cffc92b
This diff is collapsed.
......@@ -33,3 +33,5 @@ Local Modifications:
- patches/dhe_rsa.patch: Implement DHE_RSA-based cipher suites.
- patches/req_cert_types.patch: Add a reqCertTypes parameter to populate the
certificate_types field of CertificateRequest.
- patches/ignore_write_failure.patch: Don't invalidate sessions on write
failures.
diff --git a/third_party/tlslite/tlslite/tlsrecordlayer.py b/third_party/tlslite/tlslite/tlsrecordlayer.py
index 8b92221..370dc9a 100644
--- a/third_party/tlslite/tlslite/tlsrecordlayer.py
+++ b/third_party/tlslite/tlslite/tlsrecordlayer.py
@@ -286,7 +286,9 @@ class TLSRecordLayer(object):
except GeneratorExit:
raise
except Exception:
- self._shutdown(False)
+ # Don't invalidate the session on write failure if abrupt closes are
+ # okay.
+ self._shutdown(self.ignoreAbruptClose)
raise
def close(self):
......@@ -286,7 +286,9 @@ class TLSRecordLayer(object):
except GeneratorExit:
raise
except Exception:
self._shutdown(False)
# Don't invalidate the session on write failure if abrupt closes are
# okay.
self._shutdown(self.ignoreAbruptClose)
raise
def close(self):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment