Commit a0638799 authored by Bo Liu's avatar Bo Liu Committed by Commit Bot

aw: Remove features::kWebViewPageStartedOnCommit

Clean up. It's been enabled by default for awhile now.

Change-Id: Ice4ffc2d69aa8f17564293d9befe3dc3021244b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725536
Auto-Submit: Bo <boliu@chromium.org>
Reviewed-by: default avatarRichard Coles <torne@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682300}
parent 7fbc70e4
...@@ -24,7 +24,6 @@ namespace { ...@@ -24,7 +24,6 @@ namespace {
// in other locations in the code base (e.g. content/, components/, etc). // in other locations in the code base (e.g. content/, components/, etc).
const base::Feature* kFeaturesExposedToJava[] = { const base::Feature* kFeaturesExposedToJava[] = {
&features::kWebViewConnectionlessSafeBrowsing, &features::kWebViewConnectionlessSafeBrowsing,
&features::kWebViewPageStartedOnCommit,
}; };
const base::Feature* FindFeatureExposedToJava(const std::string& feature_name) { const base::Feature* FindFeatureExposedToJava(const std::string& feature_name) {
...@@ -52,11 +51,6 @@ const base::Feature kWebViewBrotliSupport{"WebViewBrotliSupport", ...@@ -52,11 +51,6 @@ const base::Feature kWebViewBrotliSupport{"WebViewBrotliSupport",
const base::Feature kWebViewConnectionlessSafeBrowsing{ const base::Feature kWebViewConnectionlessSafeBrowsing{
"WebViewConnectionlessSafeBrowsing", base::FEATURE_DISABLED_BY_DEFAULT}; "WebViewConnectionlessSafeBrowsing", base::FEATURE_DISABLED_BY_DEFAULT};
// Kill switch for feature to call onPageFinished for browser-initiated
// navigations when the navigation commits.
const base::Feature kWebViewPageStartedOnCommit{
"WebViewPageStartedOnCommit", base::FEATURE_ENABLED_BY_DEFAULT};
// Enable raster in wide color gamut for apps that use webview in a wide color // Enable raster in wide color gamut for apps that use webview in a wide color
// gamut activity. // gamut activity.
const base::Feature kWebViewWideColorGamutSupport{ const base::Feature kWebViewWideColorGamutSupport{
......
...@@ -16,7 +16,6 @@ namespace features { ...@@ -16,7 +16,6 @@ namespace features {
// Alphabetical: // Alphabetical:
extern const base::Feature kWebViewBrotliSupport; extern const base::Feature kWebViewBrotliSupport;
extern const base::Feature kWebViewConnectionlessSafeBrowsing; extern const base::Feature kWebViewConnectionlessSafeBrowsing;
extern const base::Feature kWebViewPageStartedOnCommit;
extern const base::Feature kWebViewWideColorGamutSupport; extern const base::Feature kWebViewWideColorGamutSupport;
} // namespace features } // namespace features
......
...@@ -25,7 +25,6 @@ final public class AwFeatureList { ...@@ -25,7 +25,6 @@ final public class AwFeatureList {
private static Boolean sPageStartedOnCommitForBrowserNavigations; private static Boolean sPageStartedOnCommitForBrowserNavigations;
private static boolean computePageStartedOnCommitForBrowserNavigations() { private static boolean computePageStartedOnCommitForBrowserNavigations() {
if (!nativeIsEnabled(WEBVIEW_PAGE_STARTED_ON_COMMIT)) return false;
if (GMS_PACKAGE.equals(ContextUtils.getApplicationContext().getPackageName())) { if (GMS_PACKAGE.equals(ContextUtils.getApplicationContext().getPackageName())) {
try { try {
PackageInfo gmsPackage = PackageInfo gmsPackage =
...@@ -66,7 +65,6 @@ final public class AwFeatureList { ...@@ -66,7 +65,6 @@ final public class AwFeatureList {
// Alphabetical: // Alphabetical:
public static final String WEBVIEW_CONNECTIONLESS_SAFE_BROWSING = public static final String WEBVIEW_CONNECTIONLESS_SAFE_BROWSING =
"WebViewConnectionlessSafeBrowsing"; "WebViewConnectionlessSafeBrowsing";
public static final String WEBVIEW_PAGE_STARTED_ON_COMMIT = "WebViewPageStartedOnCommit";
private static native boolean nativeIsEnabled(String featureName); private static native boolean nativeIsEnabled(String featureName);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment