Commit a0924906 authored by Nico Weber's avatar Nico Weber

Enable -Wimplicit-fallthrough on Chrome OS.

R=scottmg@chromium.org

Bug: 177475
Change-Id: I830c63748878cc8af7d1b52418a45fe7f05d1734
Reviewed-on: https://chromium-review.googlesource.com/899446Reviewed-by: default avatarScott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534520}
parent bf1583d7
...@@ -1429,8 +1429,7 @@ config("chromium_code") { ...@@ -1429,8 +1429,7 @@ config("chromium_code") {
# Warn on missing break statements at the end of switch cases. # Warn on missing break statements at the end of switch cases.
# For intentional fallthrough, use FALLTHROUGH; from base/compiler_specific.h # For intentional fallthrough, use FALLTHROUGH; from base/compiler_specific.h
# TODO(thakis): Enable for all platforms, https://crbug.com/177475 # TODO(thakis): Enable for all platforms, https://crbug.com/177475
if (is_clang && if (is_clang && (is_android || is_fuchsia || is_linux || is_win)) {
(is_android || is_fuchsia || (is_linux && !is_chromeos) || is_win)) {
cflags += [ "-Wimplicit-fallthrough" ] cflags += [ "-Wimplicit-fallthrough" ]
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment