For multiline text use the maximum of the string height and the line height...
For multiline text use the maximum of the string height and the line height while calculating the height of the text being displayed. The current code in the Canvas::SizeStringFloat function uses the passed in line_height while calculating the total height for multiline text. This works for all cases except for DirectWrite where in the text height is a touch bigger leading to it getting clipped. Example where this breaks is in the message center notifications where the line height is hardcoded to 18. We could fix notification views. However it seems like fixing canvas_skia would be better. BUG=429108 Review URL: https://codereview.chromium.org/692803004 Cr-Commit-Position: refs/heads/master@{#302704}
Showing
Please register or sign in to comment