Commit a0c93abd authored by Martin Šrámek's avatar Martin Šrámek Committed by Commit Bot

Update the aria label for the safety check reload button

The steady state button uses the aria label "Run safety check now".

Per feedback from the accessibility review, when we swap that button
with a reload button, we should also update the aria label.

We will use the label "Check again". This string already exists
in settings_strings.grdp, with a reasonably matching strings
description, so we will reuse it in order to be able to merge this
change into M83.

We will introduce a dedicated string resource in a follow-up CL
(that will not be merged into M83):
https://chromium-review.googlesource.com/c/chromium/src/+/2149418

Bug: 1070841
Change-Id: I9b9ee80a53ce0efc591d78fe384ce29748f183d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149647Reviewed-by: default avatarEsmael Elmoslimany <aee@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759112}
parent 5a122b34
......@@ -76,7 +76,7 @@
<cr-icon-button id="safetyCheckParentIconButton"
iron-icon="settings:refresh"
on-click="onRunSafetyCheckClick_"
aria-label="$i18n{safetyCheckParentButtonAriaLabel}">
aria-label="$i18n{safetyCheckParentButtonAriaLabelReload}">
</cr-icon-button>
</template>
</div>
......
......@@ -1220,6 +1220,8 @@ void AddPrivacyStrings(content::WebUIDataSource* html_source,
{"safetyCheckParentButton", IDS_SETTINGS_SAFETY_CHECK_PARENT_BUTTON},
{"safetyCheckParentButtonAriaLabel",
IDS_SETTINGS_SAFETY_CHECK_PARENT_BUTTON_ARIA_LABEL},
{"safetyCheckParentButtonAriaLabelReload",
IDS_SETTINGS_CHECK_PASSWORDS_AGAIN},
{"safetyCheckIconRunningAriaLabel",
IDS_SETTINGS_SAFETY_CHECK_ICON_RUNNING_ARIA_LABEL},
{"safetyCheckIconSafeAriaLabel",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment