[SuperSize] Remove unused param from diagnose_bloat.ResourceSizesDiff.

In daignose_bloat.py, class ResourceSizesDiff takes an |apk_name| param
at construction, but the value sits around and never gets used. This CL
removes the param, and simplifies callers.

Bug: 1040645
Change-Id: I8843018e400c3a12ce15178490c03a0a4b415963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510532Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822739}

tools/binary_size/diagnose_bloat.py

@@ -127,8 +127,7 @@ class ResourceSizesDiff(BaseDiff):
   _AGGREGATE_SECTIONS = (
       'InstallBreakdown', 'Breakdown', 'MainLibInfo', 'Uncompressed')
 
-  def __init__(self, apk_name, filename='results-chart.json'):
-    self._apk_name = apk_name
+  def __init__(self, filename='results-chart.json'):
     self._diff = None  # Set by |ProduceDiff()|
     self._filename = filename
     super(ResourceSizesDiff, self).__init__('Resource Sizes Diff')
@@ -898,9 +897,7 @@ def main():
     supersize_path, tool_prefix = paths
     diffs = [NativeDiff(build.size_name, supersize_path)]
     if build.IsAndroid():
-      diffs +=  [
-          ResourceSizesDiff(build.apk_name)
-      ]
+      diffs += [ResourceSizesDiff()]
     diff_mngr = _DiffArchiveManager(revs, args.archive_directory, diffs, build,
                                     subrepo, args.unstripped)
     consecutive_failures = 0

tools/binary_size/trybot_commit_size_checker.py

@@ -114,8 +114,8 @@ def _CreateMethodCountDelta(symbols):
                            _MAX_DEX_METHOD_COUNT_INCREASE, net_method_added)
 
 
-def _CreateResourceSizesDelta(apk_name, before_dir, after_dir):
-  sizes_diff = diagnose_bloat.ResourceSizesDiff(apk_name)
+def _CreateResourceSizesDelta(before_dir, after_dir):
+  sizes_diff = diagnose_bloat.ResourceSizesDiff()
   sizes_diff.ProduceDiff(before_dir, after_dir)
 
   return sizes_diff.Summary(), _SizeDelta(
@@ -315,8 +315,8 @@ def main():
 
   # Normalized APK Size is the main metric we use to monitor binary size.
   logging.info('Creating sizes diff')
-  resource_sizes_lines, resource_sizes_delta = (
-      _CreateResourceSizesDelta(args.apk_name, args.before_dir, args.after_dir))
+  resource_sizes_lines, resource_sizes_delta = (_CreateResourceSizesDelta(
+      args.before_dir, args.after_dir))
   size_deltas.add(resource_sizes_delta)
   metrics.add((resource_sizes_delta, _RESOURCE_SIZES_LOG))