Skip to content

GitLab

T
tangled
Commit a0dcdd24 authored by Morten Stenshorne's avatar Morten Stenshorne Committed by Commit Bot
Browse files
Options

Remove fast/multicol/balance-line-overflow.html 

This tested some behavior in the legacy fragmentation engine that wasn't
strictly valid, but was a work-around to avoid even more severe
over-stretching during column balancing. In the legacy engine, overflow
affects column sizes, which is generally wrong (but necessary when the
engine doesn't do proper fragmentation in the first place).

The LayoutNG block fragmentation engine failed this test because it just
let the lines overflow the columns (rather than stretching them to fit
the overflow), which is correct behavior.

Bug: 829028
Change-Id: I25142cad7109f028fc783578bdfe7021488cd3e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421658Reviewed-by: default avatarIan Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809106}
parent 45c327cf
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 20 deletions
third_party/blink/web_tests/TestExpectations
View file @ a0dcdd24
...@@ -1054,7 +1054,6 @@ crbug.com/829028 virtual/layout_ng_block_frag/external/wpt/css/css-multicol/mult ...@@ -1054,7 +1054,6 @@ crbug.com/829028 virtual/layout_ng_block_frag/external/wpt/css/css-multicol/mult
crbug.com/1079031 virtual/layout_ng_block_frag/fast/multicol/abspos-after-break-after.html [ Failure ] crbug.com/1079031 virtual/layout_ng_block_frag/fast/multicol/abspos-after-break-after.html [ Failure ]
crbug.com/1066616 virtual/layout_ng_block_frag/fast/multicol/abspos-in-overflow-hidden-in-2nd-column.html [ Failure ] crbug.com/1066616 virtual/layout_ng_block_frag/fast/multicol/abspos-in-overflow-hidden-in-2nd-column.html [ Failure ]
crbug.com/1079031 virtual/layout_ng_block_frag/fast/multicol/abspos-new-width-rebalance.html [ Crash Failure ] crbug.com/1079031 virtual/layout_ng_block_frag/fast/multicol/abspos-new-width-rebalance.html [ Crash Failure ]
crbug.com/829028 virtual/layout_ng_block_frag/fast/multicol/balance-line-overflow.html [ Failure ]
crbug.com/829028 virtual/layout_ng_block_frag/fast/multicol/border-radius-clipped-layer.html [ Failure ] crbug.com/829028 virtual/layout_ng_block_frag/fast/multicol/border-radius-clipped-layer.html [ Failure ]
crbug.com/829028 virtual/layout_ng_block_frag/fast/multicol/border-radius-clipped-layer-second-column.html [ Failure ] crbug.com/829028 virtual/layout_ng_block_frag/fast/multicol/border-radius-clipped-layer-second-column.html [ Failure ]
crbug.com/829028 virtual/layout_ng_block_frag/fast/multicol/break-before-first-line-in-first-child.html [ Failure ] crbug.com/829028 virtual/layout_ng_block_frag/fast/multicol/break-before-first-line-in-first-child.html [ Failure ]
......
third_party/blink/web_tests/fast/multicol/balance-line-overflow.html deleted 100644 → 0
View file @ 45c327cf
<!DOCTYPE html>
<script src="../../resources/ahem.js"></script>
<p>There should be 5 short vertical lines below.</p>
<div style="columns:6; column-gap:2px; column-rule:2px solid; width:250px; font:20px/14px Ahem; orphans:1; widows:1;">
<!-- We set a 20px tall font and a line height of 14px, so that text will overflow their line
boxes. We thus get 6px of overflow, and the text will overflow the line equally above and
below the line box, so that we have 3px on each side. The 3px of overflow below the lines
needs to be counted as space shortage by the column balancer, or it will erroneously
stretch the columns so much that two lines of text will fit in each column, leaving empty
columns at the end. Which would be silly, given that we have 6 lines of equal height and 6
columns. -->
&nbsp;<br>
&nbsp;<br>
&nbsp;<br>
&nbsp;<br>
&nbsp;<br>
&nbsp;<br>
</div>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment