Commit a0eb4481 authored by Sven Zheng's avatar Sven Zheng Committed by Chromium LUCI CQ

Reland "[Lacros] Use cfi and thin_lto for Lacros official build"

This is a reland of efe87dc0

Original issue was fixed in crrev.com/c/2584633
Locally tested Lacros can build with these gn args.

Original change's description:
> [Lacros] Use cfi and thin_lto for Lacros official build
>
> CFI and ThinLTO were disabled on the simple chrome workflow
> because they increase build time quite a bit.
> But for official build, then should be enabled.
>
> Bug: 1157567
> Change-Id: I33a9eac37221f31da9a6725b19992d5daded72dc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586085
> Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
> Reviewed-by: Sven Zheng <svenzheng@chromium.org>
> Commit-Queue: Sven Zheng <svenzheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#835956}

Bug: 1157567
Change-Id: Ib8d009f1e0e8efe8b8c3033086c9df4b6d596175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590075Reviewed-by: default avatarYuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836791}
parent 9a41227d
...@@ -1592,7 +1592,7 @@ ...@@ -1592,7 +1592,7 @@
], ],
'chromeos_amd64-generic_lacros_official': [ 'chromeos_amd64-generic_lacros_official': [
'chromeos_amd64-generic', 'amd64-lacros', 'official', 'minimal_symbols', 'chromeos_amd64-generic', 'amd64-lacros', 'official', 'minimal_symbols', 'cfi', 'thin_lto',
], ],
'chromeos_amd64-generic_lacros_rel': [ 'chromeos_amd64-generic_lacros_rel': [
......
...@@ -240,6 +240,7 @@ ...@@ -240,6 +240,7 @@
"cros_host_sysroot": "//build/linux/debian_sid_amd64-sysroot", "cros_host_sysroot": "//build/linux/debian_sid_amd64-sysroot",
"cros_v8_snapshot_sysroot": "//build/linux/debian_sid_amd64-sysroot", "cros_v8_snapshot_sysroot": "//build/linux/debian_sid_amd64-sysroot",
"enable_linux_installer": false, "enable_linux_installer": false,
"is_cfi": true,
"is_chrome_branded": true, "is_chrome_branded": true,
"is_chromeos_device": true, "is_chromeos_device": true,
"is_official_build": true, "is_official_build": true,
...@@ -260,6 +261,7 @@ ...@@ -260,6 +261,7 @@
"use_pangocairo": false, "use_pangocairo": false,
"use_pulseaudio": false, "use_pulseaudio": false,
"use_system_libsync": false, "use_system_libsync": false,
"use_thin_lto": true,
"use_v8_context_snapshot": false, "use_v8_context_snapshot": false,
"use_vaapi": false "use_vaapi": false
} }
......
...@@ -52,6 +52,7 @@ ...@@ -52,6 +52,7 @@
"cros_host_sysroot": "//build/linux/debian_sid_amd64-sysroot", "cros_host_sysroot": "//build/linux/debian_sid_amd64-sysroot",
"cros_v8_snapshot_sysroot": "//build/linux/debian_sid_amd64-sysroot", "cros_v8_snapshot_sysroot": "//build/linux/debian_sid_amd64-sysroot",
"enable_linux_installer": false, "enable_linux_installer": false,
"is_cfi": true,
"is_chrome_branded": true, "is_chrome_branded": true,
"is_chromeos_device": true, "is_chromeos_device": true,
"is_official_build": true, "is_official_build": true,
...@@ -72,6 +73,7 @@ ...@@ -72,6 +73,7 @@
"use_pangocairo": false, "use_pangocairo": false,
"use_pulseaudio": false, "use_pulseaudio": false,
"use_system_libsync": false, "use_system_libsync": false,
"use_thin_lto": true,
"use_v8_context_snapshot": false, "use_v8_context_snapshot": false,
"use_vaapi": false "use_vaapi": false
} }
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
"cros_host_sysroot": "//build/linux/debian_sid_amd64-sysroot", "cros_host_sysroot": "//build/linux/debian_sid_amd64-sysroot",
"cros_v8_snapshot_sysroot": "//build/linux/debian_sid_amd64-sysroot", "cros_v8_snapshot_sysroot": "//build/linux/debian_sid_amd64-sysroot",
"enable_linux_installer": false, "enable_linux_installer": false,
"is_cfi": true,
"is_chrome_branded": true, "is_chrome_branded": true,
"is_chromeos_device": true, "is_chromeos_device": true,
"is_official_build": true, "is_official_build": true,
...@@ -26,6 +27,7 @@ ...@@ -26,6 +27,7 @@
"use_pangocairo": false, "use_pangocairo": false,
"use_pulseaudio": false, "use_pulseaudio": false,
"use_system_libsync": false, "use_system_libsync": false,
"use_thin_lto": true,
"use_v8_context_snapshot": false, "use_v8_context_snapshot": false,
"use_vaapi": false "use_vaapi": false
} }
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
"cros_host_sysroot": "//build/linux/debian_sid_amd64-sysroot", "cros_host_sysroot": "//build/linux/debian_sid_amd64-sysroot",
"cros_v8_snapshot_sysroot": "//build/linux/debian_sid_amd64-sysroot", "cros_v8_snapshot_sysroot": "//build/linux/debian_sid_amd64-sysroot",
"enable_linux_installer": false, "enable_linux_installer": false,
"is_cfi": true,
"is_chrome_branded": true, "is_chrome_branded": true,
"is_chromeos_device": true, "is_chromeos_device": true,
"is_official_build": true, "is_official_build": true,
...@@ -26,6 +27,7 @@ ...@@ -26,6 +27,7 @@
"use_pangocairo": false, "use_pangocairo": false,
"use_pulseaudio": false, "use_pulseaudio": false,
"use_system_libsync": false, "use_system_libsync": false,
"use_thin_lto": true,
"use_v8_context_snapshot": false, "use_v8_context_snapshot": false,
"use_vaapi": false "use_vaapi": false
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment