Remove 'Details' link from new page info UI

Remove link from connection info text.
Disable click handler if no connection details can be shown.
Log UserAction when connection details are shown.

Screenshots: https://crbug.com/1077766#c26
Bug: 1077766
Change-Id: Ie87e2a1ddacbdfbcb7996c4e8f762a80964c5118
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374531Reviewed-by: Ehimare Okoyomon <eokoyomon@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802166}

components/page_info/android/java/src/org/chromium/components/page_info/PageInfoConnectionController.java

@@ -32,6 +32,7 @@ public class PageInfoConnectionController
     }
 
     private void launchSubpage() {
+        mMainController.recordAction(PageInfoAction.PAGE_INFO_SECURITY_DETAILS_OPENED);
         mMainController.launchSubpage(this);
     }
 
@@ -63,7 +64,7 @@ public class PageInfoConnectionController
         rowParams.title = mTitle;
         rowParams.subtitle = params.message != null ? params.message.toString() : null;
         rowParams.visible = rowParams.title != null || rowParams.subtitle != null;
-        rowParams.clickCallback = this::launchSubpage;
+        if (params.clickCallback != null) rowParams.clickCallback = this::launchSubpage;
         mRowView.setParams(rowParams);
     }
 

components/page_info/android/java/src/org/chromium/components/page_info/PageInfoController.java

@@ -404,7 +404,7 @@ public class PageInfoController
             messageBuilder.append(details);
         }
 
-        if (isConnectionDetailsLinkVisible()) {
+        if (!mIsV2Enabled && isConnectionDetailsLinkVisible()) {
             messageBuilder.append(" ");
             SpannableString detailsText =
                     new SpannableString(mContext.getString(R.string.details_link));
@@ -480,7 +480,8 @@ public class PageInfoController
         mContext = null;
     }
 
-    private void recordAction(int action) {
+    @Override
+    public void recordAction(@PageInfoAction int action) {
         if (mNativePageInfoController != 0) {
             PageInfoControllerJni.get().recordPageInfoAction(
                     mNativePageInfoController, PageInfoController.this, action);

components/page_info/android/java/src/org/chromium/components/page_info/PageInfoMainPageController.java

@@ -21,6 +21,13 @@ public interface PageInfoMainPageController {
      */
     void exitSubpage();
 
+    /**
+     * Record a user action.
+     *
+     * @param action The action to record.
+     */
+    void recordAction(@PageInfoAction int action);
+
     /**
      * @return A BrowserContext for this dialog.
      */