Commit a11168ca authored by Peter Kotwicz's avatar Peter Kotwicz Committed by Commit Bot

[Android] Remove duplicate resources part 1/3

This CL removes the following duplicate resource

text_size_medium
text_size_large
In both chrome/android/feed/core/java/res/values/dimens.xml and
ui/android/java/res/values/dimens.xml
Removal of duplicate is tracked in crbug.com/1039415

bottom_sheet_min_full_half_distance
bottom_sheet_peek_height
bottom_sheet_toolbar_shadow_height
bottom_sheet_shadow_top_offset
In both chrome/android/java/res/values/dimens.xml and
components/browser_ui/android/bottomsheet/java/res/values/dimens.xml
The chrome/android values should have been deleted as part of
https://chromium-review.googlesource.com/c/chromium/src/+/2242112

IDS_CERTTITLE
In both chrome/browser/ui/android/strings/android_chrome_strings.grd and
components/browser_ui/strings/android/browser_ui_strings.grd
android_chrome_strings.grd value should have been deleted as part of
https://chromium-review.googlesource.com/c/chromium/src/+/2062418

IDS_LINK_COPIED
In both chrome/browser/ui/android/strings/android_chrome_strings.grd and
ui/android/java/strings/android_ui_strings.grd
The two call sites which use the string -
ChromeProvidedSharingOptionsProvider.java and Clipboard.java -
display it in a org.chromium.ui.widget.Toast

BUG=1093825, 1039415

Change-Id: Iee21c047453eea285dc7b0a114579666bfdd582d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355314Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798165}
parent bbdd0502
...@@ -4,9 +4,6 @@ ...@@ -4,9 +4,6 @@
found in the LICENSE file. --> found in the LICENSE file. -->
<resources xmlns:tools="http://schemas.android.com/tools"> <resources xmlns:tools="http://schemas.android.com/tools">
<!-- TODO(crbug.com/1039415): Remove text size dimensions. -->
<dimen name="text_size_medium">14sp</dimen>
<dimen name="text_size_large">16sp</dimen>
<dimen name="button_compat_radius">4dp</dimen> <dimen name="button_compat_radius">4dp</dimen>
<!-- Card dimensions. --> <!-- Card dimensions. -->
<dimen name="feed_suggestion_card_action_min_height">48dp</dimen> <dimen name="feed_suggestion_card_action_min_height">48dp</dimen>
......
...@@ -487,12 +487,6 @@ ...@@ -487,12 +487,6 @@
https://www.google.com/design/spec/components/dialogs.html#dialogs-simple-dialogs --> https://www.google.com/design/spec/components/dialogs.html#dialogs-simple-dialogs -->
<dimen name="dialog_width_unit">56dp</dimen> <!-- MD dialog widths are multiples of this. --> <dimen name="dialog_width_unit">56dp</dimen> <!-- MD dialog widths are multiples of this. -->
<!-- Bottom Sheet dimensions -->
<dimen name="bottom_sheet_min_full_half_distance">140dp</dimen>
<dimen name="bottom_sheet_peek_height">56dp</dimen>
<dimen name="bottom_sheet_toolbar_shadow_height">16dp</dimen>
<dimen name="bottom_sheet_shadow_top_offset">10dp</dimen>
<!-- Miscellaneous dimensions --> <!-- Miscellaneous dimensions -->
<dimen name="text_bubble_menu_anchor_y_inset">14dp</dimen> <dimen name="text_bubble_menu_anchor_y_inset">14dp</dimen>
<!-- Used as a margin to force the shadow view to overlap other views. --> <!-- Used as a margin to force the shadow view to overlap other views. -->
......
...@@ -1444,11 +1444,6 @@ Your Google account may have other forms of browsing history like searches and a ...@@ -1444,11 +1444,6 @@ Your Google account may have other forms of browsing history like searches and a
https://families.google.com/intl/$LOCALE/familylink/privacy/child-policy/ https://families.google.com/intl/$LOCALE/familylink/privacy/child-policy/
</message> </message>
<!-- Certificate viewer -->
<message name="IDS_CERTTITLE" desc="Dialog box title for viewing security certificates. [CHAR-LIMIT=32]">
Certificate viewer
</message>
<!-- Sign-in strings --> <!-- Sign-in strings -->
<message name="IDS_SIGNOUT_TITLE" desc="Title for sign out of Chrome dialog [CHAR-LIMIT=40]"> <message name="IDS_SIGNOUT_TITLE" desc="Title for sign out of Chrome dialog [CHAR-LIMIT=40]">
Sign out and turn off sync? Sign out and turn off sync?
...@@ -3886,10 +3881,6 @@ To change this setting, <ph name="BEGIN_LINK">&lt;resetlink&gt;</ph>reset sync<p ...@@ -3886,10 +3881,6 @@ To change this setting, <ph name="BEGIN_LINK">&lt;resetlink&gt;</ph>reset sync<p
Link to text Link to text
</message> </message>
<message name="IDS_LINK_COPIED" desc="Text shown in the toast notification when Copy Link is selected in the sharing hub.">
Link Copied
</message>
<message name="IDS_TEXT_COPIED" desc="Text shown in the toast notification when Copy Text is selected in the sharing hub."> <message name="IDS_TEXT_COPIED" desc="Text shown in the toast notification when Copy Text is selected in the sharing hub.">
Text Copied Text Copied
</message> </message>
......
a1a67b055fa3286aa7b5823a4897e6c4e96e7b91
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment