Commit a12ebfd8 authored by Haiyang Pan's avatar Haiyang Pan Committed by Commit Bot

Revert "android: Add logging for local instrumentation test run to help debugging"

This reverts commit 4276efd8.

Reason for revert: The CL https://crrev.com/c/1988925 offers the same result in a better way

Original change's description:
> android: Add logging for local instrumentation test run to help debugging
> 
> Currently the builder test-n-tablet has flaky test failure due to timeout in
> apk installation.
> Adding logging to see which apk spent the most time.
> 
> This CL can be reverted after the issue 1004322 is resolved
> 
> Bug: 1004322
> Change-Id: Ic51694add3666aa0e0442cb6f8c11131e04ae13d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859904
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Haiyang Pan <hypan@google.com>
> Cr-Commit-Position: refs/heads/master@{#706212}

TBR=bpastene@chromium.org,jbudorick@chromium.org,hypan@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1004322
Change-Id: I4157e86800050f8ac051678e22224a4618118484
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993444Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#729887}
parent 51e20c87
...@@ -197,13 +197,11 @@ class LocalDeviceInstrumentationTestRun( ...@@ -197,13 +197,11 @@ class LocalDeviceInstrumentationTestRun(
@trace_event.traced @trace_event.traced
def install_helper_internal(d, apk_path=None): def install_helper_internal(d, apk_path=None):
# pylint: disable=unused-argument # pylint: disable=unused-argument
logging.info('Start Installing %s', apk.path)
d.Install( d.Install(
apk, apk,
modules=modules, modules=modules,
fake_modules=fake_modules, fake_modules=fake_modules,
permissions=permissions) permissions=permissions)
logging.info('Finished Installing %s', apk.path)
return install_helper_internal return install_helper_internal
...@@ -212,10 +210,7 @@ class LocalDeviceInstrumentationTestRun( ...@@ -212,10 +210,7 @@ class LocalDeviceInstrumentationTestRun(
@trace_event.traced @trace_event.traced
def incremental_install_helper_internal(d, apk_path=None): def incremental_install_helper_internal(d, apk_path=None):
# pylint: disable=unused-argument # pylint: disable=unused-argument
logging.info('Start Incremental Installing %s', apk.path)
installer.Install(d, json_path, apk=apk, permissions=permissions) installer.Install(d, json_path, apk=apk, permissions=permissions)
logging.info('Finished Incremental Installing %s', apk.path)
return incremental_install_helper_internal return incremental_install_helper_internal
permissions = self._test_instance.test_apk.GetPermissions() permissions = self._test_instance.test_apk.GetPermissions()
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment