[Passwords] Bug fix in Settings

Fixed spinner bug caused by removing associated-control attribute.
This change includes also minor fixes to code based on post-review
comments from previous CL.

Bug: 1056525
Change-Id: I7492936329192108870a50c1ed10ae306af659f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078546
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745416}

chrome/browser/resources/settings/autofill_page/autofill_page.html

@@ -52,6 +52,7 @@
       </template>
       <template is="dom-if" route-path="/passwords/check">
         <settings-subpage
+            associated-control="[[$$('#passwordManagerButton')]]"
             page-title="$i18n{checkPasswords}"
             learn-more-url="$i18n{passwordCheckLearnMoreURL}">
           <settings-password-check></settings-password-check>

chrome/browser/resources/settings/autofill_page/password_check.js

@@ -19,8 +19,7 @@ Polymer({
   },
 
   /**
-   * @type {PasswordManagerProxy}
-   * @private
+   * @private {PasswordManagerProxy}
    */
   passwordManager_: null,
 
@@ -43,10 +42,18 @@ Polymer({
     this.passwordManager_.startBulkPasswordCheck();
   },
 
+  /**
+   * @return {string}
+   * @private
+   */
   getLeakedPasswordsCount_() {
     return this.i18n('checkPasswordLeakCount', this.passwordLeakCount_);
   },
 
+  /**
+   * @return {string}
+   * @private
+   */
   getLastCompletedCheck_() {
     // TODO(https://crbug.com/1047726): use lastCompletedCheck_ to return proper
     // passed time from the last password check.

chrome/test/data/webui/settings/cr_settings_browsertest.js

@@ -357,10 +357,10 @@ CrSettingsPasswordsCheckTest.prototype = {
 
   /** @override */
   extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
-    'password_check_test.js',
     '../test_browser_proxy.js',
     'passwords_and_autofill_fake_data.js',
     'test_password_manager_proxy.js',
+    'password_check_test.js',
   ]),
 };
 

chrome/test/data/webui/settings/password_check_test.js

@@ -9,7 +9,7 @@ cr.define('settings_passwords_check', function() {
     // Create a passwords-section to use for testing.
     const passwordsSection =
         this.document.createElement('settings-password-check');
-    this.document.body.appendChild(passwordsSection);
+    document.body.appendChild(passwordsSection);
     Polymer.dom.flush();
     return passwordsSection;
   }