Reland "Always build ChromeVox as compressed js"
This reverts commit 9871f52a. Reason for revert: <INSERT REASONING HERE> Was not the culprit of failing chromeos dbg SpokenFeedbackTests. Original change's description: > Revert "Always build ChromeVox as compressed js" > > This reverts commit 725ceeda. > > Reason for revert: Broke lots of tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg > > chromevox test: > BackgroundTest.NavigationEscapesEdit > > interactive_ui_tests > TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/1 > LoggedInSpokenFeedbackTest.KeyboardShortcutViewer > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/1 > GuestSpokenFeedbackTest.FocusToolbar > > > Original change's description: > > Always build ChromeVox as compressed js > > > > ChromeVox can be run as both compressed (minified js) and uncompressed. The latter facilitates faster development. > > > > It appears that in some instances, with the kevin board in particular, gn evaluates the ChromeVox build file incorrectly. > > > > The end result is we end up with both uncompressed and compressed js files in ChromeVox leading to duplicate js objects. > > > > Bug: 868579 > > Test: clean build for > > 1. prior to this patch > > 2. after this patch > > > > Before each deployment, ensure we delete the chromevox folder on-device. This should be equilvanet to a new image. > > > > Change-Id: I64cf826bda9239edc7764ba598bfed6dd0572d56 > > Reviewed-on: https://chromium-review.googlesource.com/1165787 > > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > > Commit-Queue: David Tseng <dtseng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581325} > > TBR=dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com > > Change-Id: Ifb3c2556f44b07161f491b18b49d556e364963fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 868579 > Reviewed-on: https://chromium-review.googlesource.com/1167442 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581564} TBR=avi@chromium.org,dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com Change-Id: Ifb1ec50fd3cbaa1e0b97a5b5cfdb7b3b9712b353 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868579 Reviewed-on: https://chromium-review.googlesource.com/1167604Reviewed-by:David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581609}
Showing
Please register or sign in to comment