Commit a175f489 authored by Maksim Ivanov's avatar Maksim Ivanov Committed by Chromium LUCI CQ

Fix use-after-move in //c/b/thumbnail/generator/android/

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I6fbd3686d8993bdd75fe25f5849f8da39bc87550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562183
Commit-Queue: David Trainor <dtrainor@chromium.org>
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: default avatarXing Liu <xingliu@chromium.org>
Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832624}
parent 374ddfcf
...@@ -107,10 +107,11 @@ void ThumbnailGenerator::RetrieveThumbnail( ...@@ -107,10 +107,11 @@ void ThumbnailGenerator::RetrieveThumbnail(
if (base::StartsWith(mime_type, "video/", if (base::StartsWith(mime_type, "video/",
base::CompareCase::INSENSITIVE_ASCII)) { base::CompareCase::INSENSITIVE_ASCII)) {
auto parser = ThumbnailMediaParser::Create(mime_type, file_path); auto parser = ThumbnailMediaParser::Create(mime_type, file_path);
parser->Start(base::BindOnce(&ThumbnailGenerator::OnVideoThumbnailRetrieved, auto* const parser_ptr = parser.get();
weak_factory_.GetWeakPtr(), parser_ptr->Start(
std::move(java_callback), icon_size, base::BindOnce(&ThumbnailGenerator::OnVideoThumbnailRetrieved,
std::move(parser))); weak_factory_.GetWeakPtr(), std::move(java_callback),
icon_size, std::move(parser)));
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment