Commit a1768880 authored by Ryan Hamilton's avatar Ryan Hamilton Committed by Commit Bot

Change QUIC ConnectionCloseError histograms to break out errors for Google...

Change QUIC ConnectionCloseError histograms to break out errors for Google hosts in an attempt to diagnose some unexpected errors.

Change-Id: I56a795474abda715025b7fbf015d4880537c8748
Reviewed-on: https://chromium-review.googlesource.com/c/1303045Reviewed-by: default avatarNick Harper <nharper@chromium.org>
Reviewed-by: default avatarJesse Doherty <jwd@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604118}
parent 8e815bf3
...@@ -21,6 +21,7 @@ ...@@ -21,6 +21,7 @@
#include "net/base/io_buffer.h" #include "net/base/io_buffer.h"
#include "net/base/net_errors.h" #include "net/base/net_errors.h"
#include "net/base/network_activity_monitor.h" #include "net/base/network_activity_monitor.h"
#include "net/base/url_util.h"
#include "net/http/transport_security_state.h" #include "net/http/transport_security_state.h"
#include "net/log/net_log_event_type.h" #include "net/log/net_log_event_type.h"
#include "net/log/net_log_source_type.h" #include "net/log/net_log_source_type.h"
...@@ -1472,8 +1473,15 @@ void QuicChromiumClientSession::OnConnectionClosed( ...@@ -1472,8 +1473,15 @@ void QuicChromiumClientSession::OnConnectionClosed(
quic::ConnectionCloseSource source) { quic::ConnectionCloseSource source) {
DCHECK(!connection()->connected()); DCHECK(!connection()->connected());
logger_->OnConnectionClosed(error, error_details, source); logger_->OnConnectionClosed(error, error_details, source);
bool is_google_host = HasGoogleHost(GURL("https://" + session_key_.host()));
if (source == quic::ConnectionCloseSource::FROM_PEER) { if (source == quic::ConnectionCloseSource::FROM_PEER) {
if (IsCryptoHandshakeConfirmed()) { if (IsCryptoHandshakeConfirmed()) {
if (is_google_host) {
base::UmaHistogramSparse(
"Net.QuicSession.ConnectionCloseErrorCodeServerGoogle."
"HandshakeConfirmed",
error);
}
base::UmaHistogramSparse( base::UmaHistogramSparse(
"Net.QuicSession.ConnectionCloseErrorCodeServer.HandshakeConfirmed", "Net.QuicSession.ConnectionCloseErrorCodeServer.HandshakeConfirmed",
error); error);
...@@ -1484,10 +1492,20 @@ void QuicChromiumClientSession::OnConnectionClosed( ...@@ -1484,10 +1492,20 @@ void QuicChromiumClientSession::OnConnectionClosed(
if (num_streams > 0) if (num_streams > 0)
histogram->AddCount(error, num_streams); histogram->AddCount(error, num_streams);
} }
if (is_google_host) {
base::UmaHistogramSparse(
"Net.QuicSession.ConnectionCloseErrorCodeServerGoogle", error);
}
base::UmaHistogramSparse("Net.QuicSession.ConnectionCloseErrorCodeServer", base::UmaHistogramSparse("Net.QuicSession.ConnectionCloseErrorCodeServer",
error); error);
} else { } else {
if (IsCryptoHandshakeConfirmed()) { if (IsCryptoHandshakeConfirmed()) {
if (is_google_host) {
base::UmaHistogramSparse(
"Net.QuicSession.ConnectionCloseErrorCodeClientGoogle."
"HandshakeConfirmed",
error);
}
base::UmaHistogramSparse( base::UmaHistogramSparse(
"Net.QuicSession.ConnectionCloseErrorCodeClient.HandshakeConfirmed", "Net.QuicSession.ConnectionCloseErrorCodeClient.HandshakeConfirmed",
error); error);
...@@ -1504,6 +1522,10 @@ void QuicChromiumClientSession::OnConnectionClosed( ...@@ -1504,6 +1522,10 @@ void QuicChromiumClientSession::OnConnectionClosed(
connection()->IsPathDegrading()); connection()->IsPathDegrading());
} }
} }
if (is_google_host) {
base::UmaHistogramSparse(
"Net.QuicSession.ConnectionCloseErrorCodeClientGoogle", error);
}
base::UmaHistogramSparse("Net.QuicSession.ConnectionCloseErrorCodeClient", base::UmaHistogramSparse("Net.QuicSession.ConnectionCloseErrorCodeClient",
error); error);
} }
......
...@@ -58175,6 +58175,15 @@ uploading your change for review. ...@@ -58175,6 +58175,15 @@ uploading your change for review.
</summary> </summary>
</histogram> </histogram>
<histogram name="Net.QuicSession.ConnectionCloseErrorCodeClientGoogle"
enum="QuicErrorCodes">
<owner>rch@chromium.org</owner>
<summary>
The QUIC error code which resulted in the connection being closed by the
client to a server ending in .google.com.
</summary>
</histogram>
<histogram name="Net.QuicSession.ConnectionCloseErrorCodeServer" <histogram name="Net.QuicSession.ConnectionCloseErrorCodeServer"
enum="QuicErrorCodes"> enum="QuicErrorCodes">
<owner>rch@chromium.org</owner> <owner>rch@chromium.org</owner>
...@@ -58184,6 +58193,15 @@ uploading your change for review. ...@@ -58184,6 +58193,15 @@ uploading your change for review.
</summary> </summary>
</histogram> </histogram>
<histogram name="Net.QuicSession.ConnectionCloseErrorCodeServerGoogle"
enum="QuicErrorCodes">
<owner>rch@chromium.org</owner>
<summary>
The QUIC error code which resulted in the connection being closed by the
server with a name ending in .google.com.
</summary>
</histogram>
<histogram name="Net.QuicSession.ConnectionFlowControlBlocked" <histogram name="Net.QuicSession.ConnectionFlowControlBlocked"
enum="BooleanBlocked"> enum="BooleanBlocked">
<owner>rch@chromium.org</owner> <owner>rch@chromium.org</owner>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment