Set permanent text when omnibox_view_views is focused.
See the corresponding bug for situations where this was problematic. In particular, the omnibox edit model is using this permanent text to generate an AutocompleteInput object that gets sent to the autocomplete controller to generate matches. See link below for details: https://cs.chromium.org/chromium/src/components/omnibox/browser/omnibox_edit_model.cc?l=903 Baseline code does not update this permanent_text and generates an AutocompleteInput object that is inconsistent with the actual page for which suggestions are generated. For more details on what are the consequences of this inconsistency, see examples in the link for the bug. For the choice of permanent text that is used in the added line, see https://cs.chromium.org/chromium/src/chrome/browser/ui/views/omnibox/omnibox_view_views.cc?l=220 Bug: 788162 Change-Id: I10a8f088f9c5ba47dd9f0b652599c53ab3c1ecfa Reviewed-on: https://chromium-review.googlesource.com/797750 Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org> Reviewed-by:Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#520732}
Showing
Please register or sign in to comment