Commit a1a437a9 authored by Patrik Höglund's avatar Patrik Höglund Committed by Commit Bot

Disable all PasswordSaveUpdateWithAccountStoreViewTest tests.

Appears all of them can flakily time out, e.g.
https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/32044.

Observed on Win and Mac at least, in the flakiness portal.

Tbr: vasilii@chromium.org
Bug: chromium:1054629
Change-Id: I38a07613044a7fa8a79e7834e15eca3704673fd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066845Reviewed-by: default avatarPatrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743515}
parent 0bc05acc
...@@ -140,14 +140,18 @@ void PasswordSaveUpdateWithAccountStoreViewTest::CreateViewAndShow() { ...@@ -140,14 +140,18 @@ void PasswordSaveUpdateWithAccountStoreViewTest::CreateViewAndShow() {
views::BubbleDialogDelegateView::CreateBubble(view_)->Show(); views::BubbleDialogDelegateView::CreateBubble(view_)->Show();
} }
TEST_F(PasswordSaveUpdateWithAccountStoreViewTest, HasTitleAndTwoButtons) { // TODO(crbug.com/1054629): Flakily times out on all platforms.
TEST_F(PasswordSaveUpdateWithAccountStoreViewTest,
DISABLED_HasTitleAndTwoButtons) {
CreateViewAndShow(); CreateViewAndShow();
EXPECT_TRUE(view()->ShouldShowWindowTitle()); EXPECT_TRUE(view()->ShouldShowWindowTitle());
EXPECT_TRUE(view()->GetOkButton()); EXPECT_TRUE(view()->GetOkButton());
EXPECT_TRUE(view()->GetCancelButton()); EXPECT_TRUE(view()->GetCancelButton());
} }
TEST_F(PasswordSaveUpdateWithAccountStoreViewTest, ShouldNotShowAccountPicker) { // TODO(crbug.com/1054629): Flakily times out on all platforms.
TEST_F(PasswordSaveUpdateWithAccountStoreViewTest,
DISABLED_ShouldNotShowAccountPicker) {
ON_CALL(*feature_manager(), ShouldShowPasswordStorePicker) ON_CALL(*feature_manager(), ShouldShowPasswordStorePicker)
.WillByDefault(Return(false)); .WillByDefault(Return(false));
CreateViewAndShow(); CreateViewAndShow();
...@@ -164,8 +168,9 @@ TEST_F(PasswordSaveUpdateWithAccountStoreViewTest, ...@@ -164,8 +168,9 @@ TEST_F(PasswordSaveUpdateWithAccountStoreViewTest,
EXPECT_EQ(0, account_picker()->GetSelectedIndex()); EXPECT_EQ(0, account_picker()->GetSelectedIndex());
} }
// TODO(crbug.com/1054629): Flakily times out on all platforms.
TEST_F(PasswordSaveUpdateWithAccountStoreViewTest, TEST_F(PasswordSaveUpdateWithAccountStoreViewTest,
ShouldSelectAccountStoreByDefault) { DISABLED_ShouldSelectAccountStoreByDefault) {
ON_CALL(*feature_manager(), ShouldShowPasswordStorePicker) ON_CALL(*feature_manager(), ShouldShowPasswordStorePicker)
.WillByDefault(Return(true)); .WillByDefault(Return(true));
ON_CALL(*feature_manager(), GetDefaultPasswordStore) ON_CALL(*feature_manager(), GetDefaultPasswordStore)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment