Commit a1bf4c59 authored by Anthony Cui's avatar Anthony Cui Committed by Commit Bot

Add accessible name to TranslateBubbleView source_language_combobox_

Bug: 1148885
Change-Id: Ic517dddf9d4521cbe5b7338b47d74f84e251ee3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537935Reviewed-by: default avatarScott Little <sclittle@chromium.org>
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827446}
parent 4f5e284a
...@@ -8498,6 +8498,9 @@ Please help our engineers fix this problem. Tell us what happened right before y ...@@ -8498,6 +8498,9 @@ Please help our engineers fix this problem. Tell us what happened right before y
<message name="IDS_TRANSLATE_BUBBLE_COULD_NOT_TRANSLATE_TITLE" desc="Title text for the translate bubble label when the page could not be translated."> <message name="IDS_TRANSLATE_BUBBLE_COULD_NOT_TRANSLATE_TITLE" desc="Title text for the translate bubble label when the page could not be translated.">
This page could not be translated This page could not be translated
</message> </message>
<message name="IDS_TRANSLATE_BUBBLE_SOURCE_LANG_COMBOBOX_ACCNAME" desc="Accessible name for the source language selection combobox.">
Choose the page language to translate from
</message>
<message name="IDS_TRANSLATE_BUBBLE_TARGET_LANG_COMBOBOX_ACCNAME" desc="Accessible name for the target language selection combobox."> <message name="IDS_TRANSLATE_BUBBLE_TARGET_LANG_COMBOBOX_ACCNAME" desc="Accessible name for the target language selection combobox.">
Choose the language to translate the page to Choose the language to translate the page to
</message> </message>
......
da34f258f8325d10f17c6757353dd8491a93a40a
\ No newline at end of file
...@@ -812,6 +812,8 @@ std::unique_ptr<views::View> TranslateBubbleView::CreateViewAdvancedSource() { ...@@ -812,6 +812,8 @@ std::unique_ptr<views::View> TranslateBubbleView::CreateViewAdvancedSource() {
source_language_combobox->SetCallback(base::BindRepeating( source_language_combobox->SetCallback(base::BindRepeating(
&TranslateBubbleView::SourceLanguageChanged, base::Unretained(this))); &TranslateBubbleView::SourceLanguageChanged, base::Unretained(this)));
source_language_combobox->SetAccessibleName(l10n_util::GetStringUTF16(
IDS_TRANSLATE_BUBBLE_SOURCE_LANG_COMBOBOX_ACCNAME));
source_language_combobox_ = source_language_combobox.get(); source_language_combobox_ = source_language_combobox.get();
auto advanced_done_button = std::make_unique<views::MdTextButton>( auto advanced_done_button = std::make_unique<views::MdTextButton>(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment