Commit a1c0f147 authored by Hans Wennborg's avatar Hans Wennborg Committed by Commit Bot

Include-what-you-use related to logging.h (ash)

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: Ie5cb39f54fb8d0cccc03dd02ce13755169d6f8ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248687
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779361}
parent 777468b7
...@@ -12,6 +12,7 @@ ...@@ -12,6 +12,7 @@
#include "ash/public/cpp/ash_constants.h" #include "ash/public/cpp/ash_constants.h"
#include "ash/public/cpp/tablet_mode_observer.h" #include "ash/public/cpp/tablet_mode_observer.h"
#include "ash/session/session_observer.h" #include "ash/session/session_observer.h"
#include "base/callback_forward.h"
#include "base/macros.h" #include "base/macros.h"
#include "base/memory/weak_ptr.h" #include "base/memory/weak_ptr.h"
#include "base/observer_list.h" #include "base/observer_list.h"
......
...@@ -4,10 +4,8 @@ ...@@ -4,10 +4,8 @@
#include "ash/ambient/ambient_access_token_controller.h" #include "ash/ambient/ambient_access_token_controller.h"
#include <algorithm>
#include <utility>
#include "ash/public/cpp/ambient/ambient_client.h" #include "ash/public/cpp/ambient/ambient_client.h"
#include "base/logging.h"
#include "base/rand_util.h" #include "base/rand_util.h"
#include "base/time/time.h" #include "base/time/time.h"
......
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
#include "ash/app_list/model/search/search_model.h" #include "ash/app_list/model/search/search_model.h"
#include "ash/app_list/model/search/search_result.h" #include "ash/app_list/model/search/search_result.h"
#include "ash/public/cpp/app_menu_constants.h" #include "ash/public/cpp/app_menu_constants.h"
#include "base/logging.h"
#include "base/metrics/histogram_functions.h" #include "base/metrics/histogram_functions.h"
#include "base/metrics/histogram_macros.h" #include "base/metrics/histogram_macros.h"
#include "ui/compositor/compositor.h" #include "ui/compositor/compositor.h"
......
...@@ -8,6 +8,7 @@ ...@@ -8,6 +8,7 @@
#include "ash/app_list/model/app_list_item.h" #include "ash/app_list/model/app_list_item.h"
#include "base/guid.h" #include "base/guid.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h" #include "base/memory/ptr_util.h"
namespace ash { namespace ash {
......
...@@ -12,6 +12,7 @@ ...@@ -12,6 +12,7 @@
#include "ash/app_list/model/app_list_folder_item.h" #include "ash/app_list/model/app_list_folder_item.h"
#include "ash/app_list/model/app_list_item.h" #include "ash/app_list/model/app_list_item.h"
#include "ash/app_list/model/app_list_item_list_observer.h" #include "ash/app_list/model/app_list_item_list_observer.h"
#include "base/logging.h"
#include "base/macros.h" #include "base/macros.h"
#include "base/strings/stringprintf.h" #include "base/strings/stringprintf.h"
#include "testing/gtest/include/gtest/gtest.h" #include "testing/gtest/include/gtest/gtest.h"
......
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
#include "ash/app_list/model/app_list_folder_item.h" #include "ash/app_list/model/app_list_folder_item.h"
#include "ash/app_list/model/app_list_item.h" #include "ash/app_list/model/app_list_item.h"
#include "ash/app_list/model/app_list_model_observer.h" #include "ash/app_list/model/app_list_model_observer.h"
#include "base/logging.h"
namespace ash { namespace ash {
......
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
#include "ash/dbus/liveness_service_provider.h" #include "ash/dbus/liveness_service_provider.h"
#include "base/bind.h" #include "base/bind.h"
#include "base/logging.h"
#include "dbus/bus.h" #include "dbus/bus.h"
#include "dbus/message.h" #include "dbus/message.h"
#include "third_party/cros_system_api/dbus/service_constants.h" #include "third_party/cros_system_api/dbus/service_constants.h"
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
#include "ash/display/display_util.h" #include "ash/display/display_util.h"
#include "ash/strings/grit/ash_strings.h" #include "ash/strings/grit/ash_strings.h"
#include "base/logging.h"
#include "base/strings/string_number_conversions.h" #include "base/strings/string_number_conversions.h"
#include "ui/base/l10n/l10n_util.h" #include "ui/base/l10n/l10n_util.h"
#include "ui/chromeos/devicetype_utils.h" #include "ui/chromeos/devicetype_utils.h"
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
#include "ash/keyboard/ui/keyboard_ui_controller.h" #include "ash/keyboard/ui/keyboard_ui_controller.h"
#include "base/command_line.h" #include "base/command_line.h"
#include "base/logging.h"
#include "base/unguessable_token.h" #include "base/unguessable_token.h"
#include "ui/aura/window.h" #include "ui/aura/window.h"
#include "ui/base/ime/input_method.h" #include "ui/base/ime/input_method.h"
......
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
#include "ash/public/cpp/fps_counter.h" #include "ash/public/cpp/fps_counter.h"
#include "base/logging.h"
#include "ui/compositor/compositor.h" #include "ui/compositor/compositor.h"
namespace ash { namespace ash {
......
...@@ -4,6 +4,8 @@ ...@@ -4,6 +4,8 @@
#include "ash/public/cpp/keyboard/keyboard_controller.h" #include "ash/public/cpp/keyboard/keyboard_controller.h"
#include "base/check_op.h"
namespace ash { namespace ash {
// static // static
......
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
#include <ostream> #include <ostream>
#include "base/callback.h" #include "base/callback.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h" #include "base/memory/ptr_util.h"
#include "ui/gfx/presentation_feedback.h" #include "ui/gfx/presentation_feedback.h"
......
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
#include "ash/public/cpp/shelf_types.h" #include "ash/public/cpp/shelf_types.h"
#include "base/logging.h" #include "base/logging.h"
#include "base/notreached.h"
#include "base/strings/string_split.h" #include "base/strings/string_split.h"
namespace ash { namespace ash {
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
#include "base/at_exit.h" #include "base/at_exit.h"
#include "base/command_line.h" #include "base/command_line.h"
#include "base/files/file_path.h" #include "base/files/file_path.h"
#include "base/logging.h"
#include "base/path_service.h" #include "base/path_service.h"
#include "content/public/app/content_main.h" #include "content/public/app/content_main.h"
......
...@@ -4,7 +4,9 @@ ...@@ -4,7 +4,9 @@
#include "ash/shutdown_reason.h" #include "ash/shutdown_reason.h"
#include "base/logging.h" #include <ostream>
#include "base/notreached.h"
namespace ash { namespace ash {
......
...@@ -11,6 +11,7 @@ ...@@ -11,6 +11,7 @@
#include "ash/system/power/power_status.h" #include "ash/system/power/power_status.h"
#include "base/i18n/message_formatter.h" #include "base/i18n/message_formatter.h"
#include "base/i18n/time_formatting.h" #include "base/i18n/time_formatting.h"
#include "base/logging.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "base/time/time.h" #include "base/time/time.h"
#include "ui/base/l10n/l10n_util.h" #include "ui/base/l10n/l10n_util.h"
......
...@@ -11,6 +11,7 @@ ...@@ -11,6 +11,7 @@
#include "ash/system/power/battery_notification.h" #include "ash/system/power/battery_notification.h"
#include "ash/system/power/dual_role_notification.h" #include "ash/system/power/dual_role_notification.h"
#include "base/command_line.h" #include "base/command_line.h"
#include "base/logging.h"
#include "ui/base/l10n/l10n_util.h" #include "ui/base/l10n/l10n_util.h"
#include "ui/chromeos/devicetype_utils.h" #include "ui/chromeos/devicetype_utils.h"
#include "ui/message_center/message_center.h" #include "ui/message_center/message_center.h"
......
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
#include "ash/wallpaper/wallpaper_utils/wallpaper_color_calculator_observer.h" #include "ash/wallpaper/wallpaper_utils/wallpaper_color_calculator_observer.h"
#include "ash/wallpaper/wallpaper_utils/wallpaper_color_extraction_result.h" #include "ash/wallpaper/wallpaper_utils/wallpaper_color_extraction_result.h"
#include "base/bind.h" #include "base/bind.h"
#include "base/logging.h"
#include "base/metrics/histogram_macros.h" #include "base/metrics/histogram_macros.h"
#include "base/task_runner.h" #include "base/task_runner.h"
#include "base/task_runner_util.h" #include "base/task_runner_util.h"
......
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
#include "ash/public/cpp/shell_window_ids.h" #include "ash/public/cpp/shell_window_ids.h"
#include "ash/wm/desks/desk.h" #include "ash/wm/desks/desk.h"
#include "ash/wm/desks/desks_controller.h" #include "ash/wm/desks/desks_controller.h"
#include "base/logging.h"
#include "components/viz/common/frame_sinks/copy_output_request.h" #include "components/viz/common/frame_sinks/copy_output_request.h"
#include "components/viz/common/frame_sinks/copy_output_result.h" #include "components/viz/common/frame_sinks/copy_output_result.h"
#include "third_party/khronos/GLES2/gl2.h" #include "third_party/khronos/GLES2/gl2.h"
......
...@@ -8,6 +8,8 @@ ...@@ -8,6 +8,8 @@
#include <cmath> #include <cmath>
#include <memory> #include <memory>
#include "base/check_op.h"
namespace ash { namespace ash {
namespace { namespace {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment