Commit a1c5c417 authored by Ehsan Karamad's avatar Ehsan Karamad Committed by Commit Bot

Enable Test ObjectElementsViaFile

The test always passes locally however it fails when the feature
MimeHandlerViewInCrossProcessFrame is enabled. This is most likey due
to an already known issue with 'loadstop'.
Enabling the test and for now returning early when the feature is
enabled.

Bug: 964364, 840063
Change-Id: I5ff1cb29109e0994767b5dcb6c8d0af5b49158b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630521Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666390}
parent 34fdf5d0
...@@ -1221,9 +1221,12 @@ IN_PROC_BROWSER_TEST_P(SavePageOriginalVsSavedComparisonTest, ...@@ -1221,9 +1221,12 @@ IN_PROC_BROWSER_TEST_P(SavePageOriginalVsSavedComparisonTest,
} }
// Tests that saving a page from file: URI works. // Tests that saving a page from file: URI works.
// TODO(https://crbug.com/840063): Deflake and reenable.
IN_PROC_BROWSER_TEST_P(SavePageOriginalVsSavedComparisonTest, IN_PROC_BROWSER_TEST_P(SavePageOriginalVsSavedComparisonTest,
DISABLED_ObjectElementsViaFile) { ObjectElementsViaFile) {
// TODO(lukasza): https://crbug.com/964364: Re-enable the test.
if (content::MimeHandlerViewMode::UsesCrossProcessFrame())
return;
base::FilePath test_data_dir; base::FilePath test_data_dir;
ASSERT_TRUE(base::PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir)); ASSERT_TRUE(base::PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir));
GURL url(net::FilePathToFileURL( GURL url(net::FilePathToFileURL(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment