Skip to content

GitLab

T
tangled
Commit a1e5c2d0 authored by Mario Sanchez Prada's avatar Mario Sanchez Prada Committed by Commit Bot
Browse files
Options

[css-grid] Migrate flex-content-resolution-columns to WPT 

Migrate this test out of blink/web_tests/fast/css-grid-layout
and into the WPT-specific directory, adding links to the relevant
specs and a test assertion describing its purpose.

Additionally, migrate this test from being a testRunner-based reftest
with plain text expectation into a testharness.js-based test that uses
check-layout-th.js instead of the utils from the Chromium-specific
check-layout.js file, and drop the expectations file.

Last, this renames flex-and-minmax-content-resolution-columns-001.html
into flex-content-resolution-columns-002.html, since such test is
related to the one being migrated here, and that way it makes things
a bit more consistent.

Bug: 767015, 1063749
Change-Id: I06407ef10a9d9a1a7fafa0e405675e3683b23250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146544Reviewed-by: default avatarChristian Biesinger <cbiesinger@chromium.org>
Reviewed-by: default avatarManuel Rego <rego@igalia.com>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#759179}
parent 542169b4
Hide whitespace changes
Inline Side-by-side
Showing with 17 additions and 23 deletions
third_party/blink/web_tests/fast/css-grid-layout/flex-content-resolution-columns.html → third_party/blink/web_tests/external/wpt/css/css-grid/grid-definition/flex-content-resolution-columns-001.html
View file @ a1e5c2d0
<!DOCTYPE html> <!DOCTYPE html>
<html> <html>
<link href="resources/grid.css" rel="stylesheet"> <title>CSS Grid Layout Test: Auto repeat tracks, grid-template-columns and flexible lengths.</title>
<link rel="author" title="Julien Chaffraix" href="mailto:jchaffraix@chromium.org">
<link rel="help" href="https://drafts.csswg.org/css-grid-1/#track-sizes">
<link rel="help" href="https://drafts.csswg.org/css-grid-1/#fr-unit">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=235258">
<link rel="stylesheet" href="/fonts/ahem.css">
<link rel="stylesheet" href="/css/support/grid.css">
<meta name="assert" content="Test that resolving auto tracks on grid items using <flex> values with grid-template-columns works properly." />
<style> <style>
.gridFlexContent { .gridFlexContent {
grid-template-columns: 1fr 1fr; grid-template-columns: 1fr 1fr;
...@@ -44,10 +52,15 @@ ...@@ -44,10 +52,15 @@
grid-row: 1; grid-row: 1;
} }
</style> </style>
<script src="../../resources/check-layout.js"></script>
<body onload="checkLayout('.grid');">
<p>Test that resolving auto tracks on grid items works properly.</p> <script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/check-layout-th.js"></script>
<script type="text/javascript">
setup({ explicit_done: true });
</script>
<body onload="document.fonts.ready.then(() => { checkLayout('.grid'); })">
<div class="constrainedContainer" style="position: relative"> <div class="constrainedContainer" style="position: relative">
<div class="grid gridFlexContent"> <div class="grid gridFlexContent">
......
third_party/blink/web_tests/fast/css-grid-layout/flex-content-resolution-columns-expected.txt deleted 100644 → 0
View file @ 542169b4
Test that resolving auto tracks on grid items works properly.
XXX
XXXXX
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment