Update Media.VideoPersistence.* histograms.

Removing one not very useful and noisy enum entry and updating the timeframe as
there will be more work on Picture-in-Picture for Android soon.

Bug: 1125691, 1125690
Change-Id: I6190852d0129311590287cb11e2f6538f54c071b
Fixed: 1125691, 1125690
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463983Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816807}

chrome/android/java/src/org/chromium/chrome/browser/media/PictureInPictureController.java

@@ -62,7 +62,7 @@ public class PictureInPictureController {
     private static final int METRICS_ATTEMPT_RESULT_RESTARTING = 5;
     private static final int METRICS_ATTEMPT_RESULT_FINISHING = 6;
     private static final int METRICS_ATTEMPT_RESULT_NO_WEBCONTENTS = 7;
-    private static final int METRICS_ATTEMPT_RESULT_NO_VIDEO = 8;
+    // private static final int METRICS_ATTEMPT_RESULT_NO_VIDEO = 8;
     private static final int METRICS_ATTEMPT_RESULT_COUNT = 9;
 
     private static final String METRICS_END_REASON = "Media.VideoPersistence.EndReason";
@@ -109,7 +109,6 @@ public class PictureInPictureController {
         // Only auto-PiP if there is a playing fullscreen video that allows PiP.
         if (!webContents.hasActiveEffectivelyFullscreenVideo()
                 || !webContents.isPictureInPictureAllowedForFullscreenVideo()) {
-            recordAttemptResult(METRICS_ATTEMPT_RESULT_NO_VIDEO);
             return false;
         }
 

tools/metrics/histograms/enums.xml

@@ -74401,7 +74401,7 @@ Full version information for the fingerprint enum values:
   <int value="5" label="Restarting"/>
   <int value="6" label="Finishing"/>
   <int value="7" label="No WebContents"/>
-  <int value="8" label="No video"/>
+  <int value="8" label="(Obsolete) No video"/>
 </enum>
 
 <enum name="VideoPersistenceControlsType">

tools/metrics/histograms/histograms_xml/media/histograms.xml

@@ -3905,7 +3905,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
 </histogram>
 
 <histogram name="Media.VideoPersistence.AttemptResult"
-    enum="VideoPersistenceAttemptResult" expires_after="M87">
+    enum="VideoPersistenceAttemptResult" expires_after="M93">
   <owner>mlamouri@google.com</owner>
   <owner>peconn@chromium.org</owner>
   <owner>media-dev@chromium.org</owner>
@@ -3916,7 +3916,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
 </histogram>
 
 <histogram name="Media.VideoPersistence.ControlsType"
-    enum="VideoPersistenceControlsType" expires_after="M87">
+    enum="VideoPersistenceControlsType" expires_after="M93">
   <owner>mlamouri@google.com</owner>
   <owner>media-dev@chromium.org</owner>
   <summary>
@@ -3926,7 +3926,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
 </histogram>
 
 <histogram name="Media.VideoPersistence.Duration" units="ms"
-    expires_after="M87">
+    expires_after="M93">
   <owner>mlamouri@google.com</owner>
   <owner>peconn@chromium.org</owner>
   <owner>media-dev@chromium.org</owner>
@@ -3937,7 +3937,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
 </histogram>
 
 <histogram name="Media.VideoPersistence.EndReason"
-    enum="VideoPersistenceEndReason" expires_after="M87">
+    enum="VideoPersistenceEndReason" expires_after="M93">
   <owner>mlamouri@google.com</owner>
   <owner>peconn@chromium.org</owner>
   <owner>media-dev@chromium.org</owner>