Commit a23460e7 authored by Robert Ma's avatar Robert Ma Committed by Chromium LUCI CQ

Update WPT-NOTIFY docs to use DIR_METADATA

Metadata have been migrated from the comment in OWNERS to DIR_METADATA.

Change-Id: I6c035d8ce37df2289cdb12e800c286cd3b8642ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598898
Auto-Submit: Robert Ma <robertma@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: default avatarStephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838560}
parent 28703371
...@@ -139,8 +139,9 @@ Please see the `wpt_internal` ...@@ -139,8 +139,9 @@ Please see the `wpt_internal`
**Note**: A significant downside of `wpt_internal` is that your tests may be **Note**: A significant downside of `wpt_internal` is that your tests may be
broken by upstream changes to the resources scripts (e.g. `testharness.js`), as broken by upstream changes to the resources scripts (e.g. `testharness.js`), as
`wpt_internal` does not use the forked version of `testharness.js` used by all `wpt_internal` does not use the forked version of `testharness.js` used by all
other non-`external/wpt` tests. Use of [WPT-NOTIFY](#wpt_notify) is recommended other non-`external/wpt` tests. Use of [new failure
to ensure you are notified of breakages. notifications](#new-failure-notifications) is recommended to ensure you are
notified of breakages.
## Running tests ## Running tests
...@@ -200,19 +201,24 @@ For maintainers: ...@@ -200,19 +201,24 @@ For maintainers:
- If the importer starts misbehaving, it can be disabled by landing a - If the importer starts misbehaving, it can be disabled by landing a
[CL to skip the update step](https://crrev.com/c/1961906/). [CL to skip the update step](https://crrev.com/c/1961906/).
### WPT-NOTIFY ### New failure notifications
Test owners can elect to have the importer automatically file bugs against a Test owners can elect to have the importer automatically file bugs against a
component when imported changes introduce failures. This includes new tests that component when imported changes introduce failures. This includes new tests that
fail in Chromium, as well as new failures introduced to an existing test. To fail in Chromium, as well as new failures introduced to an existing test. To
opt-in to this functionality, create an `OWNERS` file in the appropriate opt-in to this functionality, create an `DIR_METADATA` file in the appropriate
`external/wpt/` subdirectory that contains the `WPT-NOTIFY` tag. For example, `external/wpt/` subdirectory that contains at least `wpt.notify` and
`external/wpt/css/css-grid/OWNERS` looks like: `monorail.component` fields. For example, `external/wpt/css/css-grid/DIR_METADATA`
looks like:
``` ```
# TEAM: layout-dev@chromium.org monorail {
# COMPONENT: Blink>Layout>Grid component: "Blink>Layout>Grid"
# WPT-NOTIFY: true }
team_email: "layout-dev@chromium.org"
wpt {
notify: YES
}
``` ```
When a test under `external/wpt/css/css-grid/` newly fails in a WPT import, the When a test under `external/wpt/css/css-grid/` newly fails in a WPT import, the
...@@ -220,8 +226,8 @@ importer will automatically file a bug against the Blink>Layout>Grid component ...@@ -220,8 +226,8 @@ importer will automatically file a bug against the Blink>Layout>Grid component
in [crbug.com][https://crbug.com], with details of which test failed and the in [crbug.com][https://crbug.com], with details of which test failed and the
output. output.
Note that we are considering making WPT-NOTIFY opt-out instead of opt-in: see Note that we are considering making the notifications opt-out instead of
https://crbug.com/845232 opt-in: see https://crbug.com/845232
### Skipped tests (and how to re-enable them) ### Skipped tests (and how to re-enable them)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment