[iOS][DarkMode] Move favicon background color to common

This color is also going to be used in popup menu.

Bug: 976645
Change-Id: I7259415ba23aa7bbad24a5eb79794da0a3100389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735377
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684278}

ios/chrome/browser/ui/table_view/cells/BUILD.gn

@@ -46,7 +46,6 @@ source_set("cells") {
     "resources:table_view_cell_chevron",
     "resources:table_view_cell_edit_icon",
     "resources:table_view_cell_favicon_background",
-    "resources:table_view_favicon_background_color",
     "//base",
     "//base:i18n",
     "//ios/chrome/app/strings",

ios/chrome/browser/ui/table_view/cells/resources/BUILD.gn

@@ -38,9 +38,3 @@ imageset("table_view_cell_edit_icon") {
     "table_view_cell_edit_icon.imageset/table_view_cell_edit_icon@3x.png",
   ]
 }
-
-colorset("table_view_favicon_background_color") {
-  sources = [
-    "table_view_favicon_background_color.colorset/Contents.json",
-  ]
-}

ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm

@@ -150,7 +150,7 @@ const char kDefaultSupplementalURLTextDelimiter[] = "•";
     _faviconContainerView =
         [[UIImageView alloc] initWithImage:containerBackground];
     _faviconContainerView.tintColor =
-        [UIColor colorNamed:@"table_view_favicon_background_color"];
+        [UIColor colorNamed:kFaviconBackgroundColor];
 
     _faviconView = [[FaviconView alloc] init];
     _faviconView.contentMode = UIViewContentModeScaleAspectFit;

ios/chrome/common/colors/resources/BUILD.gn

@@ -11,6 +11,7 @@ group("resources") {
     ":blue_color",
     ":blue_dark_color",
     ":disabled_tint_color",
+    ":favicon_background_color",
     ":green_color",
     ":green_dark_color",
     ":mdc_ink_color",
@@ -60,6 +61,12 @@ colorset("disabled_tint_color") {
   ]
 }
 
+colorset("favicon_background_color") {
+  sources = [
+    "favicon_background_color.colorset/Contents.json",
+  ]
+}
+
 colorset("green_color") {
   sources = [
     "green_color.colorset/Contents.json",

ios/chrome/common/colors/semantic_color_names.h

@@ -11,6 +11,8 @@
 
 extern NSString* const kBackgroundColor;
 extern NSString* const kDisabledTintColor;
+// Background color used in the rounded squares behind favicons.
+extern NSString* const kFaviconBackgroundColor;
 extern NSString* const kMDCInkColor;
 extern NSString* const kScrimBackgroundColor;
 extern NSString* const kSolidButtonTextColor;

ios/chrome/common/colors/semantic_color_names.mm

@@ -11,6 +11,7 @@
 #pragma mark - Element Colors
 NSString* const kBackgroundColor = @"background_color";
 NSString* const kDisabledTintColor = @"disabled_tint_color";
+NSString* const kFaviconBackgroundColor = @"favicon_background_color";
 NSString* const kMDCInkColor = @"mdc_ink_color";
 NSString* const kScrimBackgroundColor = @"scrim_background_color";
 NSString* const kSolidButtonTextColor = @"solid_button_text_color";