WebUI: Change remaining 'tap' listeners to native 'click'.

In this CL ignoring 'tap' listeners residing in CrOS only code, or
code that is about to be removed soon.

Bug: 812035
Change-Id: I31e32b29908c25675a430bcaa0c30d6b7d1f7ee1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446021
Commit-Queue: John Lee <johntlee@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814320}

chrome/browser/resources/settings/controls/controlled_button.html

@@ -18,14 +18,14 @@
       }
 
       :host([enforced_]) {
-        /* Disable pointer events for this whole element, as outer on-tap gets
-         * triggered when clicking/tapping anywhere in :host. */
+        /* Disable pointer events for this whole element, as outer on-click gets
+         * triggered when clicking anywhere in :host. */
         pointer-events: none;
       }
 
       cr-policy-pref-indicator {
         /* Enable pointer events for the indicator so :hover works. Disable
-         * clicks/taps via onIndicatorTap_ so outer on-tap doesn't trigger. */
+         * clicks via onIndicatorClick_ so outer on-click doesn't trigger. */
         pointer-events: all;
       }
 
@@ -47,7 +47,7 @@
     </cr-button>
 
     <template is="dom-if" if="[[hasPrefPolicyIndicator(pref.*)]]" restamp>
-      <cr-policy-pref-indicator pref="[[pref]]" on-click="onIndicatorTap_"
+      <cr-policy-pref-indicator pref="[[pref]]" on-click="onIndicatorClick_"
           icon-aria-label="[[label]]">
       </cr-policy-pref-indicator>
     </template>

chrome/browser/resources/settings/controls/controlled_button.js

@@ -52,7 +52,7 @@ Polymer({
    * @param {!Event} e
    * @private
    */
-  onIndicatorTap_(e) {
+  onIndicatorClick_(e) {
     // Disallow <controlled-button on-click="..."> when controlled.
     e.preventDefault();
     e.stopPropagation();

ui/webui/resources/cr_components/certificate_manager/certificate_subentry.html

@@ -22,28 +22,28 @@
       <cr-policy-indicator indicator-type="[[getPolicyIndicatorType_(model)]]">
       </cr-policy-indicator>
       <cr-icon-button class="icon-more-vert" id="dots"
-          title="[[i18n('moreActions')]]" on-click="onDotsTap_">
+          title="[[i18n('moreActions')]]" on-click="onDotsClick_">
       </cr-icon-button>
       <cr-lazy-render id="menu">
         <template>
           <cr-action-menu role-description="[[i18n('menu')]]">
             <button class="dropdown-item" id="view"
-                on-tap="onViewTap_">
+                on-click="onViewClick_">
               [[i18n('certificateManagerView')]]
             </button>
             <button class="dropdown-item" id="edit"
                 hidden$="[[!canEdit_(model)]]"
-                on-tap="onEditTap_">
+                on-click="onEditClick_">
               [[i18n('edit')]]
             </button>
             <button class="dropdown-item" id="export"
                 hidden$="[[!canExport_(certificateType, model)]]"
-                on-tap="onExportTap_">
+                on-click="onExportClick_">
               [[i18n('certificateManagerExport')]]
             </button>
             <button class="dropdown-item" id="delete"
                 hidden$="[[!canDelete_(model)]]"
-                on-tap="onDeleteTap_">
+                on-click="onDeleteClick_">
               [[i18n('certificateManagerDelete')]]
             </button>
           </cr-action-menu>

ui/webui/resources/cr_components/certificate_manager/certificate_subentry.js

@@ -79,38 +79,26 @@ Polymer({
     this.fire('certificates-error', {error: error, anchor: this.$.dots});
   },
 
-  /**
-   * @param {!Event} event
-   * @private
-   */
-  onViewTap_(event) {
+  /** @private */
+  onViewClick_() {
     this.closePopupMenu_();
     this.browserProxy_.viewCertificate(this.model.id);
   },
 
-  /**
-   * @param {!Event} event
-   * @private
-   */
-  onEditTap_(event) {
+  /** @private */
+  onEditClick_() {
     this.closePopupMenu_();
     this.dispatchCertificateActionEvent_(CertificateAction.EDIT);
   },
 
-  /**
-   * @param {!Event} event
-   * @private
-   */
-  onDeleteTap_(event) {
+  /** @private */
+  onDeleteClick_() {
     this.closePopupMenu_();
     this.dispatchCertificateActionEvent_(CertificateAction.DELETE);
   },
 
-  /**
-   * @param {!Event} event
-   * @private
-   */
-  onExportTap_(event) {
+  /** @private */
+  onExportClick_() {
     this.closePopupMenu_();
     if (this.certificateType === CertificateType.PERSONAL) {
       this.browserProxy_.exportPersonalCertificate(this.model.id).then(() => {
@@ -158,7 +146,7 @@ Polymer({
   },
 
   /** @private */
-  onDotsTap_() {
+  onDotsClick_() {
     const actionMenu = /** @type {!CrActionMenuElement} */ (this.$.menu.get());
     actionMenu.showAt(this.$.dots);
   },

ui/webui/resources/cr_elements/cr_radio_button/cr_radio_button_style_css.html

@@ -38,8 +38,8 @@
 
       :host([disabled]) {
         opacity: var(--cr-disabled-opacity);
-        /* Disable pointer events for this whole element, as outer on-tap gets
-         * triggered when clicking/tapping anywhere in :host. */
+        /* Disable pointer events for this whole element, as outer on-click gets
+         * triggered when clicking anywhere in :host. */
         pointer-events: none;
       }