Commit a2647269 authored by Ewann's avatar Ewann Committed by Commit Bot

[iOS] Fixes tableView separator

This CL removes the top separtor of the Cookies tableView.

Bug: 1064961
Change-Id: I4a91b8ee567642d838c93034b57bbba87e41d1a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149654Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759574}
parent 82c12e80
......@@ -42,7 +42,7 @@
- (void)start {
self.viewController = [[PrivacyCookiesViewController alloc]
initWithStyle:UITableViewStyleGrouped];
initWithStyle:UITableViewStylePlain];
DCHECK(self.baseNavigationController);
[self.baseNavigationController pushViewController:self.viewController
......
......@@ -7,8 +7,7 @@
#import "ios/chrome/browser/ui/settings/cells/settings_multiline_detail_item.h"
#import "ios/chrome/browser/ui/settings/privacy/cookies_commands.h"
#import "ios/chrome/browser/ui/settings/settings_navigation_controller.h"
#import "ios/chrome/browser/ui/table_view/cells/table_view_link_header_footer_item.h"
#import "ios/chrome/browser/ui/table_view/cells/table_view_text_header_footer_item.h"
#import "ios/chrome/browser/ui/table_view/cells/table_view_text_link_item.h"
#import "ios/chrome/browser/ui/table_view/chrome_table_view_styler.h"
#import "ios/chrome/common/ui/colors/UIColor+cr_semantic_colors.h"
#import "ios/chrome/common/ui/colors/semantic_color_names.h"
......@@ -112,13 +111,15 @@ typedef NS_ENUM(NSInteger, SectionIdentifier) {
[self.tableViewModel addItem:blockAllCookies
toSectionWithIdentifier:SectionIdentifierContent];
TableViewLinkHeaderFooterItem* cookiesDescriptionFooter =
[[TableViewLinkHeaderFooterItem alloc]
// This item is used as a footer. It's currently not possible to have a
// separtor without using UITableViewStyleGrouped.
TableViewTextLinkItem* cookiesDescriptionFooter =
[[TableViewTextLinkItem alloc]
initWithType:ItemTypeCookiesDescriptionFooter];
cookiesDescriptionFooter.text =
l10n_util::GetNSString(IDS_IOS_OPTIONS_PRIVACY_COOKIES_DESCRIPTION);
[self.tableViewModel setFooter:cookiesDescriptionFooter
forSectionWithIdentifier:SectionIdentifierContent];
[self.tableViewModel addItem:cookiesDescriptionFooter
toSectionWithIdentifier:SectionIdentifierContent];
// TODO(crbug.com/1064961): Implement this.
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment