Commit a28c6848 authored by Sigurdur Asgeirsson's avatar Sigurdur Asgeirsson Committed by Commit Bot

RC: Bump default render CPU sampling interval to 10 minutes.

R=chrisha@chromium.org

Bug: 755840
Change-Id: Ife8febb03b0fb8d48b864b9987488d90893c4bbf
Reviewed-on: https://chromium-review.googlesource.com/1005408
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: default avatarChris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551458}
parent 48a4a526
...@@ -24,7 +24,8 @@ namespace resource_coordinator { ...@@ -24,7 +24,8 @@ namespace resource_coordinator {
namespace { namespace {
const int kDefaultMeasurementIntervalInSeconds = 1; constexpr base::TimeDelta kDefaultMeasurementInterval =
base::TimeDelta::FromMinutes(10);
base::LazyInstance<ResourceCoordinatorRenderProcessProbe>::DestructorAtExit base::LazyInstance<ResourceCoordinatorRenderProcessProbe>::DestructorAtExit
g_probe = LAZY_INSTANCE_INITIALIZER; g_probe = LAZY_INSTANCE_INITIALIZER;
...@@ -71,8 +72,7 @@ class ResourceCoordinatorRenderProcessMetricsHandler ...@@ -71,8 +72,7 @@ class ResourceCoordinatorRenderProcessMetricsHandler
ResourceCoordinatorRenderProcessProbe::ResourceCoordinatorRenderProcessProbe() ResourceCoordinatorRenderProcessProbe::ResourceCoordinatorRenderProcessProbe()
: metrics_handler_( : metrics_handler_(
std::make_unique<ResourceCoordinatorRenderProcessMetricsHandler>()), std::make_unique<ResourceCoordinatorRenderProcessMetricsHandler>()),
interval_ms_( interval_(kDefaultMeasurementInterval) {
base::TimeDelta::FromSeconds(kDefaultMeasurementIntervalInSeconds)) {
UpdateWithFieldTrialParams(); UpdateWithFieldTrialParams();
} }
...@@ -178,7 +178,7 @@ void ResourceCoordinatorRenderProcessProbe:: ...@@ -178,7 +178,7 @@ void ResourceCoordinatorRenderProcessProbe::
HandleRenderProcessMetricsOnUIThread() { HandleRenderProcessMetricsOnUIThread() {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI); DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (metrics_handler_->HandleMetrics(render_process_info_map_)) { if (metrics_handler_->HandleMetrics(render_process_info_map_)) {
timer_.Start(FROM_HERE, interval_ms_, this, timer_.Start(FROM_HERE, interval_, this,
&ResourceCoordinatorRenderProcessProbe:: &ResourceCoordinatorRenderProcessProbe::
RegisterAliveRenderProcessesOnUIThread); RegisterAliveRenderProcessesOnUIThread);
} }
...@@ -200,7 +200,7 @@ void ResourceCoordinatorRenderProcessProbe::UpdateWithFieldTrialParams() { ...@@ -200,7 +200,7 @@ void ResourceCoordinatorRenderProcessProbe::UpdateWithFieldTrialParams() {
int64_t interval_ms = GetGRCRenderProcessCPUProfilingIntervalInMs(); int64_t interval_ms = GetGRCRenderProcessCPUProfilingIntervalInMs();
if (interval_ms > 0) { if (interval_ms > 0) {
interval_ms_ = base::TimeDelta::FromMilliseconds(interval_ms); interval_ = base::TimeDelta::FromMilliseconds(interval_ms);
} }
} }
......
...@@ -85,8 +85,8 @@ class ResourceCoordinatorRenderProcessProbe { ...@@ -85,8 +85,8 @@ class ResourceCoordinatorRenderProcessProbe {
// A map of currently running ProcessHandles to Process. // A map of currently running ProcessHandles to Process.
RenderProcessInfoMap render_process_info_map_; RenderProcessInfoMap render_process_info_map_;
// Time duration between measurements in milliseconds. // Time duration between measurements.
base::TimeDelta interval_ms_; base::TimeDelta interval_;
// Timer to signal the |ResourceCoordinatorRenderProcessProbe| instance // Timer to signal the |ResourceCoordinatorRenderProcessProbe| instance
// to conduct its measurements as a regular interval; // to conduct its measurements as a regular interval;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment