Skip to content

GitLab

T
tangled
Commit a29eb756 authored by mnaganov@chromium.org's avatar mnaganov@chromium.org
Browse files
Options

[android_webview] GetTitleTest.testGetTitleWithWriteln -> ...testGetTitleSetFromJS 

First, turning on JS, which is disabled by default.

Also, no one guarantees that onload + writeln + onPageFinished must work as
you'd expect, so there is no point in testing this scenario. So just change this
test to verify that the title updated via JS is reported by GetTitle.

BUG=151012

Review URL: https://codereview.chromium.org/117993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243537 0039d316-1c4b-4281-b951-d872f2087c98
parent f898b175
Hide whitespace changes
Inline Side-by-side
Showing with 7 additions and 13 deletions
android_webview/javatests/src/org/chromium/android_webview/test/GetTitleTest.java
View file @ a29eb756
...@@ -8,7 +8,6 @@ import android.test.suitebuilder.annotation.SmallTest; ...@@ -8,7 +8,6 @@ import android.test.suitebuilder.annotation.SmallTest;
import android.test.suitebuilder.annotation.Smoke; import android.test.suitebuilder.annotation.Smoke;
import org.chromium.android_webview.AwContents; import org.chromium.android_webview.AwContents;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.net.test.util.TestWebServer; import org.chromium.net.test.util.TestWebServer;
...@@ -149,21 +148,16 @@ public class GetTitleTest extends AwTestBase { ...@@ -149,21 +148,16 @@ public class GetTitleTest extends AwTestBase {
assertEquals("Incorrect title :: " , info.mUrl, info.mTitle); assertEquals("Incorrect title :: " , info.mUrl, info.mTitle);
} }
/** @SmallTest
* A subtle bug started to appear after the merge to r157579. If document.writeln is @Feature({"AndroidWebView"})
* used in the page's script then the page's title is reported incorrectly. public void testGetTitleSetFromJS() throws Throwable {
* Bug: crbug.com/151012
* @SmallTest
* @Feature({"AndroidWebView"})
*/
@DisabledTest
public void testGetTitleWithWriteln() throws Throwable {
final String expectedTitle = "Expected"; final String expectedTitle = "Expected";
final String page = final String page =
// Note: document.title="...";document.writeln(document.title); also fails. "<html><head>" +
"<html>" + "<script>document.title=\"" + expectedTitle + "\"</script>" +
"<body onload='document.writeln(document.title=\"" + expectedTitle + "\")'>" + "</head><body>" +
"</body></html>"; "</body></html>";
getAwSettingsOnUiThread(mAwContents).setJavaScriptEnabled(true);
final String title = loadFromDataAndGetTitle(page); final String title = loadFromDataAndGetTitle(page);
assertEquals("Incorrect title :: ", expectedTitle, title); assertEquals("Incorrect title :: ", expectedTitle, title);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment