Skip to content

GitLab

T
tangled
Commit a2bc4303 authored by Julie Jeongeun Kim's avatar Julie Jeongeun Kim Committed by Commit Bot
Browse files
Options

[css-grid] Migrate grid-element-min-max-height.html to WPT 

This CL migrates grid-element-min-max-height.html to
external/wpt/css/css-grid/grid-model, adding links to the relevant
specs and a test assertion describing its purpose, renaming it to
grid-min-max-height-001.html.

Bug: 1063749
Change-Id: I883f37b92e69daf841f47eb3d93983c5c1ad7a48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154363
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: default avatarManuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#760020}
parent 61ba7bbd
Hide whitespace changes
Inline Side-by-side
Showing with 8 additions and 18 deletions
third_party/blink/web_tests/fast/css-grid-layout/grid-element-min-max-height.html → third_party/blink/web_tests/external/wpt/css/css-grid/grid-model/grid-min-max-height-001.html
View file @ a2bc4303
<!DOCTYPE html> <!DOCTYPE html>
<html> <html>
<link href="resources/grid.css" rel="stylesheet"> <title>CSS Grid: min-height and max-height</title>
<link rel="author" title="Julien Chaffraix" href="mailto:jchaffraix@chromium.org">
<link rel="help" href="https://drafts.csswg.org/css-grid/#intrinsic-sizes">
<link rel="stylesheet" href="/css/support/grid.css">
<meta name="assert" content="This test checks that min-height and max-height are accounted for when computing the grid container's height.">
<style> <style>
.minHeightGrid { .minHeightGrid {
min-height: 100px; min-height: 100px;
...@@ -21,11 +25,11 @@ ...@@ -21,11 +25,11 @@
max-height: 100px; max-height: 100px;
} }
</style> </style>
<script src="../../resources/check-layout.js"></script> <script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/check-layout-th.js"></script>
<body onload="checkLayout('.grid')"> <body onload="checkLayout('.grid')">
<p>Test that min-height and max-height are accounted for when computing the grid element's height.</p>
<div class="constrainedContainer"> <div class="constrainedContainer">
<div class="grid minHeightGrid" data-expected-height="100" data-expected-width="10"></div> <div class="grid minHeightGrid" data-expected-height="100" data-expected-width="10"></div>
<div class="grid maxHeightGrid" data-expected-height="100" data-expected-width="10"></div> <div class="grid maxHeightGrid" data-expected-height="100" data-expected-width="10"></div>
......
third_party/blink/web_tests/fast/css-grid-layout/grid-element-min-max-height-expected.txt deleted 100644 → 0
View file @ 61ba7bbd
Test that min-height and max-height are accounted for when computing the grid element's height.
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment