Commit a2ce72e4 authored by Ian Vollick's avatar Ian Vollick Committed by Commit Bot

[vr] Disable WillNotFailOnNonAsciiURLs

This will currently not pass with new versions of HarfBuzz.

Bug: 731894
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib5ae456bf44bfdedd6a0edf36b54dbbf12bae18a
Reviewed-on: https://chromium-review.googlesource.com/1169774
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: default avatarMichael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582298}
parent 6bb8985e
...@@ -10,10 +10,10 @@ ...@@ -10,10 +10,10 @@
namespace vr { namespace vr {
#if !defined(OS_LINUX) && !defined(OS_WIN)
// TODO(crbug/731894): This test does not work on Linux. // TODO(crbug/731894): This test does not work on Linux.
// TODO(crbug/770893): This test does not work on Windows. // TODO(crbug/770893): This test does not work on Windows.
TEST(UrlText, WillNotFailOnNonAsciiURLs) { // TODO(crbug/731894): This test does not work on Android, either.
TEST(UrlText, DISABLED_WillNotFailOnNonAsciiURLs) {
bool unhandled_code_point = false; bool unhandled_code_point = false;
auto url_text = std::make_unique<UrlText>( auto url_text = std::make_unique<UrlText>(
0.010, base::BindRepeating([](bool* flag) { *flag = true; }, 0.010, base::BindRepeating([](bool* flag) { *flag = true; },
...@@ -23,7 +23,6 @@ TEST(UrlText, WillNotFailOnNonAsciiURLs) { ...@@ -23,7 +23,6 @@ TEST(UrlText, WillNotFailOnNonAsciiURLs) {
url_text->PrepareToDrawForTest(); url_text->PrepareToDrawForTest();
EXPECT_EQ(false, unhandled_code_point); EXPECT_EQ(false, unhandled_code_point);
} }
#endif
TEST(UrlText, WillFailOnUnhandledCodePoint) { TEST(UrlText, WillFailOnUnhandledCodePoint) {
bool unhandled_code_point; bool unhandled_code_point;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment