Commit a2e04dd1 authored by Michael Lippautz's avatar Michael Lippautz Committed by Commit Bot

node: Remove operator new override

All uses must go through MakeGarbageCollected.

Bug: 945806
Change-Id: I825ac265bb6a18cbaf0b5393e70bec671cf15ab1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613298
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659953}
parent 46ce6edf
......@@ -165,8 +165,6 @@ class CORE_EXPORT Node : public EventTarget {
// Override operator new to allocate Node subtype objects onto
// a dedicated heap.
GC_PLUGIN_IGNORE("crbug.com/443854")
void* operator new(size_t size) { return AllocateObject(size, false); }
static void* AllocateObject(size_t size, bool is_eager) {
ThreadState* state =
ThreadStateFor<ThreadingTrait<Node>::kAffinity>::GetState();
......
......@@ -98,14 +98,14 @@ void MediaControlAnimatedArrowContainerElement::ShowArrowAnimation(
MediaControlsResourceLoader::GetAnimatedArrowStyleSheet());
shadow_root->ParserAppendChild(style);
left_jump_arrow_ =
new MediaControlAnimatedArrowContainerElement::AnimatedArrow(
"left-arrow", GetDocument());
left_jump_arrow_ = MakeGarbageCollected<
MediaControlAnimatedArrowContainerElement::AnimatedArrow>(
"left-arrow", GetDocument());
shadow_root->ParserAppendChild(left_jump_arrow_);
right_jump_arrow_ =
new MediaControlAnimatedArrowContainerElement::AnimatedArrow(
"right-arrow", GetDocument());
right_jump_arrow_ = MakeGarbageCollected<
MediaControlAnimatedArrowContainerElement::AnimatedArrow>(
"right-arrow", GetDocument());
shadow_root->ParserAppendChild(right_jump_arrow_);
}
......
......@@ -17,9 +17,9 @@ class MediaControlAnimatedArrowContainerElementTest : public PageTestBase {
void SetUp() final {
// Create page and instance of AnimatedArrow to run tests on.
PageTestBase::SetUp();
arrow_element_ =
new MediaControlAnimatedArrowContainerElement::AnimatedArrow(
"test", GetDocument());
arrow_element_ = MakeGarbageCollected<
MediaControlAnimatedArrowContainerElement::AnimatedArrow>(
"test", GetDocument());
GetDocument().body()->AppendChild(arrow_element_);
}
......
......@@ -1669,7 +1669,7 @@ void MediaControlsImpl::HandleTouchEvent(Event* event) {
void MediaControlsImpl::EnsureAnimatedArrowContainer() {
if (!animated_arrow_container_element_) {
animated_arrow_container_element_ =
new MediaControlAnimatedArrowContainerElement(*this);
MakeGarbageCollected<MediaControlAnimatedArrowContainerElement>(*this);
ParserAppendChild(animated_arrow_container_element_);
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment