Commit a2e30027 authored by Matt Reynolds's avatar Matt Reynolds Committed by Chromium LUCI CQ

[gamepad] Add todo for Xbox HID vibration detection

Bug: 1030841
Change-Id: Ie79eba7a869784ece023aea5ab499b7618128dc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582628
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Auto-Submit: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839643}
parent f66bc9a8
...@@ -20,6 +20,11 @@ XboxHidController::~XboxHidController() = default; ...@@ -20,6 +20,11 @@ XboxHidController::~XboxHidController() = default;
// static // static
bool XboxHidController::IsXboxHid(GamepadId gamepad_id) { bool XboxHidController::IsXboxHid(GamepadId gamepad_id) {
// TODO(crbug/1030841): Detect haptics functionality through HID usages
// instead of relying on a hard-coded list of supported device IDs.
// Bluetooth-connected Xbox One gamepads expose usages from the Physical
// Interface Device usage page.
// https://www.usb.org/document-library/device-class-definition-pid-10
return gamepad_id == GamepadId::kMicrosoftProduct02e0 || return gamepad_id == GamepadId::kMicrosoftProduct02e0 ||
gamepad_id == GamepadId::kMicrosoftProduct02fd || gamepad_id == GamepadId::kMicrosoftProduct02fd ||
gamepad_id == GamepadId::kMicrosoftProduct0b05; gamepad_id == GamepadId::kMicrosoftProduct0b05;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment