Commit a2e8a849 authored by Tom Lukaszewicz's avatar Tom Lukaszewicz Committed by Josip Sokcevic

Tab Search: Fix closure_compile for TabSearchSearchField

Updated JSDoc information to support using the CrSearchFieldBehavior
with with the non-legacy class based Polymer3 syntax.

Related CL: https://crrev.com/c/2333208

Bug: 1099917
Change-Id: Id514a5b20e19700a3f7b2948f6a2c7f36caf8d58
Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3194288Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819574}
parent 38a88569
...@@ -7,11 +7,19 @@ import 'chrome://resources/cr_elements/shared_vars_css.m.js'; ...@@ -7,11 +7,19 @@ import 'chrome://resources/cr_elements/shared_vars_css.m.js';
import 'chrome://resources/polymer/v3_0/iron-icon/iron-icon.js'; import 'chrome://resources/polymer/v3_0/iron-icon/iron-icon.js';
import './shared_vars.js'; import './shared_vars.js';
import {CrSearchFieldBehavior} from 'chrome://resources/cr_elements/cr_search_field/cr_search_field_behavior.m.js'; import {CrSearchFieldBehavior, CrSearchFieldBehaviorInterface} from 'chrome://resources/cr_elements/cr_search_field/cr_search_field_behavior.m.js';
import {html, PolymerElement, mixinBehaviors} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js'; import {html, mixinBehaviors, PolymerElement} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js';
class TabSearchSearchField extends mixinBehaviors( /**
[CrSearchFieldBehavior], PolymerElement) { * @constructor
* @extends {PolymerElement}
* @implements {CrSearchFieldBehaviorInterface}
*/
const TabSearchSearchFieldBase =
mixinBehaviors([ CrSearchFieldBehavior ], PolymerElement);
/** @polymer */
export class TabSearchSearchField extends TabSearchSearchFieldBase {
static get is() { static get is() {
return 'tab-search-search-field'; return 'tab-search-search-field';
......
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
import {keyDownOn} from 'chrome://resources/polymer/v3_0/iron-test-helpers/mock-interactions.js'; import {keyDownOn} from 'chrome://resources/polymer/v3_0/iron-test-helpers/mock-interactions.js';
import {TabSearchAppElement} from 'chrome://tab-search/app.js'; import {TabSearchAppElement} from 'chrome://tab-search/app.js';
import {TabSearchSearchField} from 'chrome://tab-search/tab_search_search_field.js';
import {TabSearchApiProxy, TabSearchApiProxyImpl} from 'chrome://tab-search/tab_search_api_proxy.js' import {TabSearchApiProxy, TabSearchApiProxyImpl} from 'chrome://tab-search/tab_search_api_proxy.js'
import {assertEquals, assertTrue} from '../../chai_assert.js'; import {assertEquals, assertTrue} from '../../chai_assert.js';
...@@ -116,7 +117,7 @@ suite('TabSearchAppTest', () => { ...@@ -116,7 +117,7 @@ suite('TabSearchAppTest', () => {
test('return filtered tabs', async () => { test('return filtered tabs', async () => {
await setupTest(sampleData()); await setupTest(sampleData());
const searchField = /** @type {!TabSearchSearchFieldElement} */ const searchField = /** @type {!TabSearchSearchField} */
(tabSearchApp.shadowRoot.querySelector("#searchField")); (tabSearchApp.shadowRoot.querySelector("#searchField"));
searchField.setValue('bing'); searchField.setValue('bing');
await flushTasks(); await flushTasks();
...@@ -133,7 +134,7 @@ suite('TabSearchAppTest', () => { ...@@ -133,7 +134,7 @@ suite('TabSearchAppTest', () => {
test('Keyboard navigation on an empty list', async () => { test('Keyboard navigation on an empty list', async () => {
await setupTest({windows: [{active: true, tabs: []}]}); await setupTest({windows: [{active: true, tabs: []}]});
const searchField = /** @type {!TabSearchSearchFieldElement} */ const searchField = /** @type {!TabSearchSearchField} */
(tabSearchApp.shadowRoot.querySelector("#searchField")); (tabSearchApp.shadowRoot.querySelector("#searchField"));
keyDownOn(searchField, 0, [], 'ArrowUp'); keyDownOn(searchField, 0, [], 'ArrowUp');
...@@ -154,7 +155,7 @@ suite('TabSearchAppTest', () => { ...@@ -154,7 +155,7 @@ suite('TabSearchAppTest', () => {
const numTabs = const numTabs =
sampleData().windows.reduce((total, w) => total + w.tabs.length, 0); sampleData().windows.reduce((total, w) => total + w.tabs.length, 0);
const searchField = /** @type {!TabSearchSearchFieldElement} */ const searchField = /** @type {!TabSearchSearchField} */
(tabSearchApp.shadowRoot.querySelector("#searchField")); (tabSearchApp.shadowRoot.querySelector("#searchField"));
keyDownOn(searchField, 0, [], 'ArrowUp'); keyDownOn(searchField, 0, [], 'ArrowUp');
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment