Remove #success logging from BreadcrumbManagerTabHelper::PageLoaded

"Success" will be the most common page load result and can be omitted as
default.

Bug: 2056565
Change-Id: I866aa24ea6da824fd3ff7c11f72fd4ca5acd1ee5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057784
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742246}

ios/chrome/browser/crash_report/breadcrumbs/breadcrumb_manager_tab_helper.h

@@ -48,10 +48,6 @@ extern const char kBreadcrumbPageLoadFailure[];
 // Page.
 extern const char kBreadcrumbNtpNavigation[];
 
-// Appended to |kBreadcrumbPageLoaded| event if page load has
-// succeeded.
-extern const char kBreadcrumbPageLoadSuccess[];
-
 // Appended to |kBreadcrumbDidStartNavigation| event if navigation
 // was a client side redirect (f.e. window.open without user gesture).
 extern const char kBreadcrumbRendererInitiatedByScript[];

ios/chrome/browser/crash_report/breadcrumbs/breadcrumb_manager_tab_helper.mm

@@ -39,7 +39,6 @@ const char kBreadcrumbDownload[] = "#download";
 const char kBreadcrumbMixedContent[] = "#mixed";
 const char kBreadcrumbNtpNavigation[] = "#ntp";
 const char kBreadcrumbPageLoadFailure[] = "#failure";
-const char kBreadcrumbPageLoadSuccess[] = "#success";
 const char kBreadcrumbRendererInitiatedByUser[] = "#renderer-user";
 const char kBreadcrumbRendererInitiatedByScript[] = "#renderer-script";
 
@@ -135,7 +134,6 @@ void BreadcrumbManagerTabHelper::PageLoaded(
   } else {
     switch (load_completion_status) {
       case web::PageLoadCompletionStatus::SUCCESS:
-        event.push_back(kBreadcrumbPageLoadSuccess);
         break;
       case web::PageLoadCompletionStatus::FAILURE:
         event.push_back(kBreadcrumbPageLoadFailure);

ios/chrome/browser/crash_report/breadcrumbs/breadcrumb_manager_tab_helper_unittest.mm

@@ -275,8 +275,6 @@ TEST_F(BreadcrumbManagerTabHelperTest, PageLoadSuccess) {
 
   EXPECT_NE(std::string::npos, events.back().find(kBreadcrumbPageLoaded))
       << events.back();
-  EXPECT_NE(std::string::npos, events.back().find(kBreadcrumbPageLoadSuccess))
-      << events.back();
   EXPECT_EQ(std::string::npos, events.back().find(kBreadcrumbPageLoadFailure))
       << events.back();
 }
@@ -292,8 +290,6 @@ TEST_F(BreadcrumbManagerTabHelperTest, PageLoadFailure) {
 
   EXPECT_NE(std::string::npos, events.back().find(kBreadcrumbPageLoaded))
       << events.back();
-  EXPECT_EQ(std::string::npos, events.back().find(kBreadcrumbPageLoadSuccess))
-      << events.back();
   EXPECT_NE(std::string::npos, events.back().find(kBreadcrumbPageLoadFailure))
       << events.back();
 }