Commit a2f5c165 authored by behdad's avatar behdad Committed by Commit Bot

High confidence interval should not invalidate data

High confidence intervals are not failing the test anymore (except for
control test), so it should also not invalidate the recorded averages.

Bug: chromium:1052054
Change-Id: I016bf25c6229102a9b74255d9ee4b6a32fc1e0f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072125
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: default avatarCaleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744410}
parent 1af86888
...@@ -136,11 +136,7 @@ def parse_csv_results(csv_obj, upper_limit_data): ...@@ -136,11 +136,7 @@ def parse_csv_results(csv_obj, upper_limit_data):
if (row['avg'] == '' or row['count'] == 0): if (row['avg'] == '' or row['count'] == 0):
continue continue
values_per_story[story_name]['ci_095'].append(float(row['ci_095'])) values_per_story[story_name]['ci_095'].append(float(row['ci_095']))
values_per_story[story_name]['averages'].append(float(row['avg']))
upper_limit_ci = upper_limit_data[story_name]['ci_095']
# Only average values which are not noisy will be used
if (float(row['ci_095']) <= upper_limit_ci * CI_ERROR_MARGIN):
values_per_story[story_name]['averages'].append(float(row['avg']))
return values_per_story return values_per_story
......
...@@ -98,16 +98,14 @@ class TestRepresentativePerfScript(unittest.TestCase): ...@@ -98,16 +98,14 @@ class TestRepresentativePerfScript(unittest.TestCase):
self.assertEquals(values_per_story['story_1']['ci_095'], [1.5]) self.assertEquals(values_per_story['story_1']['ci_095'], [1.5])
# Record with avg 12 has high noise. # Record with avg 12 has high noise.
self.assertEquals(values_per_story['story_3']['averages'], [8.0, 7.0]) self.assertEquals(values_per_story['story_3']['averages'], [8.0, 7.0, 12.0])
self.assertEquals(values_per_story['story_3']['ci_095'], [2.0, 15.0, 16.0]) self.assertEquals(values_per_story['story_3']['ci_095'], [2.0, 15.0, 16.0])
self.assertEquals(len(values_per_story['story_4']['averages']), 0) self.assertEquals(len(values_per_story['story_4']['averages']), 0)
self.assertEquals(len(values_per_story['story_4']['ci_095']), 0) self.assertEquals(len(values_per_story['story_4']['ci_095']), 0)
self.assertEquals(len(values_per_story['story_5']['averages']), 0) self.assertEquals(len(values_per_story['story_5']['averages']), 0)
self.assertEquals(len(values_per_story['story_5']['ci_095']), 0) self.assertEquals(len(values_per_story['story_5']['ci_095']), 0)
self.assertEquals(values_per_story['story_6']['averages'], [12.0])
# High noise record will be filtered.
self.assertEquals(len(values_per_story['story_6']['averages']), 0)
self.assertEquals(values_per_story['story_6']['ci_095'], [40.0]) self.assertEquals(values_per_story['story_6']['ci_095'], [40.0])
def test_compare_values_1(self): def test_compare_values_1(self):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment