Commit a302d192 authored by Eugene But's avatar Eugene But Committed by Commit Bot

Fix WebFaviconDriver::GetActiveURL.

According to the code's comments (and caller's expectations), the method
should return last committed URL instead of visible URL.

"last committed URL" is URL of the page, while "visible URL" is the URL
which should be displayed in the omnibox (one that the user has typed
for example).

Bug: 897506
Change-Id: I13148cc2dee62c707cbceebab0d8d19622f942b8
Reviewed-on: https://chromium-review.googlesource.com/c/1316427Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605363}
parent 74136aa0
......@@ -60,7 +60,7 @@ bool WebFaviconDriver::FaviconIsValid() const {
GURL WebFaviconDriver::GetActiveURL() {
web::NavigationItem* item =
web_state_->GetNavigationManager()->GetVisibleItem();
web_state_->GetNavigationManager()->GetLastCommittedItem();
return item ? item->GetURL() : GURL();
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment