Settings: passwords and forms, clear password from view on update

Bug: 865899
Change-Id: Ic759da99d5dd11f2e08b201b731bab8006da7b38
Reviewed-on: https://chromium-review.googlesource.com/1145625
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577625}

chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.js

@@ -10,14 +10,17 @@
 Polymer({
   is: 'password-list-item',
 
-  behaviors: [FocusRowBehavior, ShowPasswordBehavior],
+  behaviors: [
+    FocusRowBehavior,
+    ShowPasswordBehavior,
+  ],
 
   /**
    * Selects the password on tap if revealed.
    * @private
    */
   onReadonlyInputTap_: function() {
-    if (this.password)
+    if (this.item.password)
       this.$$('#password').select();
   },
 

chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

@@ -150,25 +150,30 @@ Polymer({
 
   /** @override */
   attached: function() {
+    // The item uid is built from index, origin, and username for the
+    // following reasons: origin and username are enough to describe and
+    // uniquely identify an entry. It is impossible to have two entries
+    // that have the same origin and username, but different passwords,
+    // as the password update logic prevents these cases. The entry is
+    // required to force a refresh of entries, after a removal or undo of
+    // a removal has taken place. All entries before the point of
+    // modification are uneffected, but the ones following need to be
+    // refreshed. Including the index in the uid achieves this effect.
+    // See https://crbug.com/862119 how this could lead to bugs otherwise.
+    const getItemUid =
+        item => [item.entry.index, item.entry.loginPair.urls.origin,
+                 item.entry.loginPair.username]
+                    .join('_');
+
     // Create listener functions.
-    const setSavedPasswordsListener = list =>
-        this.updateList('savedPasswords', item => {
-          // The item uid is built from index, origin, and username for the
-          // following reasons: origin and username are enough to describe and
-          // uniquely identify an entry. It is impossible to have two entries
-          // that have the same origin and username, but different passwords,
-          // as the password update logic prevents these cases. The entry is
-          // required to force a refresh of entries, after a removal or undo of
-          // a removal has taken place. All entries before the point of
-          // modification are uneffected, but the ones following need to be
-          // refreshed. Including the index in the uid achieves this effect.
-          // See https://crbug.com/862119 how this could lead to bugs otherwise.
-          return item.entry.index + '_' + item.entry.loginPair.urls.origin +
-              '_' + item.entry.loginPair.username;
-        }, list.map(entry => ({
-                      entry: entry,
-                      password: '',
-                    })));
+    const setSavedPasswordsListener = list => {
+      const newList = list.map(entry => ({entry: entry, password: ''}));
+      this.updateList('savedPasswords', getItemUid, newList);
+      this.savedPasswords.forEach((item, index) => {
+        item.password = '';
+        this.$.passwordList.notifyPath(`items.${index}.password`);
+      });
+    };
 
     const setPasswordExceptionsListener = list => {
       this.passwordExceptions = list;