Fix WPTs access to ICE transport object from DTLS transport object.

The ICE transport object has been renamed in DTLS idl from transport to
iceTransport. Update WPTs accordingly.

Mark the ice connection state test flaky for now because the state surfaced
in blink layer is currently not consistent with the state in WebRTC layer.

Bug: 907849
Change-Id: Ifc88cb8e877ce15729c355f54c85cc1a34556d0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533878
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649049}

third_party/blink/web_tests/TestExpectations

@@ -5819,6 +5819,8 @@ crbug.com/920979 virtual/webrtc-wpt-plan-b/external/wpt/webrtc/RTCTrackEvent-fir
 # WebRTC codec tests - software H.264 not present on webkit bot family
 crbug.com/840659 external/wpt/webrtc/protocol/video-codecs.https.html [ Pass Failure ]
 crbug.com/840659 virtual/webrtc-wpt-plan-b/external/wpt/webrtc/protocol/video-codecs.https.html [ Pass Failure ]
+# WebRTC IceTransport flaky test
+crbug.com/944036 external/wpt/webrtc/RTCPeerConnection-iceConnectionState.https.html [ Pass Failure ]
 
 # Sheriff 2019-01-11
 crbug.com/921038 virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials/webexposed/legacy-performance-memory-counters-enabled.html [ Skip ]

third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-iceConnectionState.https-expected.txt

@@ -2,7 +2,7 @@ This is a testharness.js-based test.
 PASS Initial iceConnectionState should be new
 PASS Closing the connection should set iceConnectionState to closed
 PASS connection with one data channel should eventually have connected or completed connection state
-FAIL connection with one data channel should eventually have connected connection state Cannot read property 'state' of undefined
+FAIL connection with one data channel should eventually have connected connection state assert_equals: Expect ICE transport to be in checking state when iceConnectionState is checking expected "checking" but got "closed"
 PASS ICE can connect in a recvonly usecase
 Harness: the test ran to completion.
 

third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-iceConnectionState.https.html

@@ -148,21 +148,21 @@ async_test(t => {
       const { iceConnectionState } = pc1;
 
       if(iceConnectionState === 'checking') {
-        const iceTransport = pc1.sctp.transport.transport;
+        const iceTransport = pc1.sctp.transport.iceTransport;
 
         assert_equals(iceTransport.state, 'checking',
           'Expect ICE transport to be in checking state when' +
           ' iceConnectionState is checking');
 
       } else if(iceConnectionState === 'connected') {
-        const iceTransport = pc1.sctp.transport.transport;
+        const iceTransport = pc1.sctp.transport.iceTransport;
 
         assert_equals(iceTransport.state, 'connected',
           'Expect ICE transport to be in connected state when' +
           ' iceConnectionState is connected');
 
       } else if(iceConnectionState === 'completed') {
-        const iceTransport = pc1.sctp.transport.transport;
+        const iceTransport = pc1.sctp.transport.iceTransport;
 
         assert_equals(iceTransport.state, 'completed',
           'Expect ICE transport to be in connected state when' +

third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-iceGatheringState-expected.txt

 This is a testharness.js-based test.
 PASS Initial iceGatheringState should be new
 PASS iceGatheringState should eventually become complete after setLocalDescription
-FAIL connection with one data channel should eventually have connected connection state Cannot read property 'gatheringState' of undefined
+FAIL connection with one data channel should eventually have connected connection state assert_equals: Expect ICE transport to be in checking gatheringState when iceGatheringState is checking expected (string) "gathering" but got (undefined) undefined
 Harness: the test ran to completion.
 

third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-iceGatheringState.html

@@ -108,13 +108,13 @@
       const { iceGatheringState } = pc2;
 
       if(iceGatheringState === 'gathering') {
-        const iceTransport = pc2.sctp.transport.transport;
+        const iceTransport = pc2.sctp.transport.iceTransport;
 
         assert_equals(iceTransport.gatheringState, 'gathering',
           'Expect ICE transport to be in checking gatheringState when iceGatheringState is checking');
 
       } else if(iceGatheringState === 'complete') {
-        const iceTransport = pc2.sctp.transport.transport;
+        const iceTransport = pc2.sctp.transport.iceTransport;
 
         assert_equals(iceTransport.gatheringState, 'complete',
           'Expect ICE transport to be in complete gatheringState when iceGatheringState is complete');