Commit a331a725 authored by Trent Apted's avatar Trent Apted Committed by Commit Bot

Remove unused BrowserWindow::ExecuteExtensionCommand()

Git archaeology suggests callers of this method disappeared in r754621.

Bug: 894447
Change-Id: I24a1818950be53131fd781d07c19a096d138db6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460071Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815327}
parent 5aa280a6
......@@ -244,12 +244,6 @@ bool ExtensionKeybindingRegistry::IsEventTargetsEmpty() const {
return event_targets_.empty();
}
void ExtensionKeybindingRegistry::ExecuteCommand(
const std::string& extension_id,
const ui::Accelerator& accelerator) {
ExecuteCommands(accelerator, extension_id);
}
void ExtensionKeybindingRegistry::OnExtensionLoaded(
content::BrowserContext* browser_context,
const Extension* extension) {
......
......@@ -63,11 +63,6 @@ class ExtensionKeybindingRegistry : public CommandService::Observer,
return shortcut_handling_suspended_;
}
// Execute the command bound to |accelerator| and provided by the extension
// with |extension_id|, if it exists.
void ExecuteCommand(const std::string& extension_id,
const ui::Accelerator& accelerator);
// Check whether the specified |accelerator| has been registered.
bool IsAcceleratorRegistered(const ui::Accelerator& accelerator) const;
......
......@@ -56,11 +56,6 @@ struct NativeWebKeyboardEvent;
enum class KeyboardEventProcessingResult;
} // namespace content
namespace extensions {
class Command;
class Extension;
} // namespace extensions
namespace gfx {
class Size;
}
......@@ -475,10 +470,6 @@ class BrowserWindow : public ui::BaseWindow {
// |site_id| is the site identification of the survey the bubble leads to.
virtual void ShowHatsBubble(const std::string& site_id) = 0;
// Executes |command| registered by |extension|.
virtual void ExecuteExtensionCommand(const extensions::Extension* extension,
const extensions::Command& command) = 0;
// Returns object implementing ExclusiveAccessContext interface.
virtual ExclusiveAccessContext* GetExclusiveAccessContext() = 0;
......
......@@ -3416,13 +3416,6 @@ void BrowserView::ShowHatsBubble(const std::string& site_id) {
HatsBubbleView::ShowOnContentReady(browser(), site_id);
}
void BrowserView::ExecuteExtensionCommand(
const extensions::Extension* extension,
const extensions::Command& command) {
extension_keybinding_registry_->ExecuteCommand(extension->id(),
command.accelerator());
}
ExclusiveAccessContext* BrowserView::GetExclusiveAccessContext() {
return this;
}
......
......@@ -76,11 +76,6 @@ class TopControlsSlideControllerTest;
class WebContentsCloseHandler;
class WebUITabStripContainerView;
namespace extensions {
class Command;
class Extension;
}
#if defined(OS_CHROMEOS)
namespace ui {
class ThroughputTracker;
......@@ -467,8 +462,6 @@ class BrowserView : public BrowserWindow,
signin_metrics::AccessPoint access_point,
bool is_source_keyboard) override;
void ShowHatsBubble(const std::string& site_id) override;
void ExecuteExtensionCommand(const extensions::Extension* extension,
const extensions::Command& command) override;
ExclusiveAccessContext* GetExclusiveAccessContext() override;
std::string GetWorkspace() const override;
bool IsVisibleOnAllWorkspaces() const override;
......
......@@ -237,10 +237,6 @@ web_modal::WebContentsModalDialogHost*
return NULL;
}
void TestBrowserWindow::ExecuteExtensionCommand(
const extensions::Extension* extension,
const extensions::Command& command) {}
ExclusiveAccessContext* TestBrowserWindow::GetExclusiveAccessContext() {
return nullptr;
}
......
......@@ -26,10 +26,6 @@ class FeaturePromoController;
class LocationBarTesting;
class OmniboxView;
namespace extensions {
class Extension;
}
namespace qrcode_generator {
class QRCodeGeneratorBubbleController;
class QRCodeGeneratorBubbleView;
......@@ -184,8 +180,6 @@ class TestBrowserWindow : public BrowserWindow {
void ShowHatsBubble(const std::string& site_id) override {}
#endif
void ExecuteExtensionCommand(const extensions::Extension* extension,
const extensions::Command& command) override;
ExclusiveAccessContext* GetExclusiveAccessContext() override;
std::string GetWorkspace() const override;
bool IsVisibleOnAllWorkspaces() const override;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment