[Android][Signin] Move logSigninStartAccessPoint to SigninMetricsUtils

This CL moves the method logSigninStartAccessPoint to
SigninMetricsUtils to group the metrics logging methods in one place.

Bug: 1163476
Change-Id: Ib06a01d2a72bcd4c27ef4e66f77aa96300638261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611733Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841969}

chrome/android/java/src/org/chromium/chrome/browser/firstrun/SigninFirstRunFragment.java

@@ -16,7 +16,7 @@ import org.chromium.base.metrics.RecordUserAction;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ntp.cards.SignInPromo;
 import org.chromium.chrome.browser.signin.SigninFragmentBase;
-import org.chromium.chrome.browser.signin.services.SigninManager;
+import org.chromium.chrome.browser.signin.services.SigninMetricsUtils;
 import org.chromium.components.signin.AccountManagerFacadeProvider;
 import org.chromium.components.signin.ChildAccountStatus;
 import org.chromium.components.signin.metrics.SigninAccessPoint;
@@ -52,7 +52,7 @@ public class SigninFirstRunFragment extends SigninFragmentBase implements FirstR
                 "Signin.AndroidDeviceAccountsNumberWhenEnteringFRE", Math.min(numAccounts, 2));
         RecordUserAction.record("MobileFre.SignInShown");
         RecordUserAction.record("Signin_Signin_FromStartPage");
-        SigninManager.logSigninStartAccessPoint(SigninAccessPoint.START_PAGE);
+        SigninMetricsUtils.logSigninStartAccessPoint(SigninAccessPoint.START_PAGE);
     }
 
     @Override

chrome/android/java/src/org/chromium/chrome/browser/signin/SigninFragment.java

@@ -21,6 +21,7 @@ import org.chromium.chrome.browser.settings.SettingsLauncher;
 import org.chromium.chrome.browser.settings.SettingsLauncherImpl;
 import org.chromium.chrome.browser.signin.services.IdentityServicesProvider;
 import org.chromium.chrome.browser.signin.services.SigninManager;
+import org.chromium.chrome.browser.signin.services.SigninMetricsUtils;
 import org.chromium.chrome.browser.signin.services.UnifiedConsentServiceBridge;
 import org.chromium.chrome.browser.sync.ProfileSyncService;
 import org.chromium.chrome.browser.sync.settings.ManageSyncSettings;
@@ -118,7 +119,7 @@ public class SigninFragment extends SigninFragmentBase {
         mPromoAction =
                 getSigninArguments().getInt(ARGUMENT_PERSONALIZED_PROMO_ACTION, PromoAction.NONE);
 
-        SigninManager.logSigninStartAccessPoint(mSigninAccessPoint);
+        SigninMetricsUtils.logSigninStartAccessPoint(mSigninAccessPoint);
         recordSigninStartedHistogramAccountInfo();
         recordSigninStartedUserAction();
     }

chrome/browser/signin/services/android/java/src/org/chromium/chrome/browser/signin/services/SigninManager.java

@@ -10,7 +10,6 @@ import androidx.annotation.MainThread;
 import androidx.annotation.Nullable;
 
 import org.chromium.base.Callback;
-import org.chromium.base.metrics.RecordHistogram;
 import org.chromium.components.signin.base.CoreAccountInfo;
 import org.chromium.components.signin.identitymanager.IdentityManager;
 import org.chromium.components.signin.metrics.SigninAccessPoint;
@@ -82,17 +81,6 @@ public interface SigninManager {
         void signOutComplete();
     }
 
-    /**
-     * Logs the access point when the user see the view of choosing account to sign in. Sign-in
-     * completion histogram is recorded by {@link #signinAndEnableSync}.
-     *
-     * @param accessPoint {@link SigninAccessPoint} that initiated the sign-in flow.
-     */
-    static void logSigninStartAccessPoint(@SigninAccessPoint int accessPoint) {
-        RecordHistogram.recordEnumeratedHistogram(
-                "Signin.SigninStartedAccessPoint", accessPoint, SigninAccessPoint.MAX);
-    }
-
     /**
      * Extracts the domain name of a given account's email.
      */

chrome/browser/signin/services/android/java/src/org/chromium/chrome/browser/signin/services/SigninMetricsUtils.java

@@ -11,6 +11,7 @@ import org.chromium.base.metrics.RecordHistogram;
 import org.chromium.chrome.browser.profiles.ProfileAccountManagementMetrics;
 import org.chromium.components.signin.GAIAServiceType;
 import org.chromium.components.signin.metrics.AccountConsistencyPromoAction;
+import org.chromium.components.signin.metrics.SigninAccessPoint;
 
 /**
  * Util methods for signin metrics logging.
@@ -42,6 +43,17 @@ public class SigninMetricsUtils {
                 100);
     }
 
+    /**
+     * Logs the access point when the user see the view of choosing account to sign in. Sign-in
+     * completion histogram is recorded by {@link SigninManager#signinAndEnableSync}.
+     *
+     * @param accessPoint {@link SigninAccessPoint} that initiated the sign-in flow.
+     */
+    public static void logSigninStartAccessPoint(@SigninAccessPoint int accessPoint) {
+        RecordHistogram.recordEnumeratedHistogram(
+                "Signin.SigninStartedAccessPoint", accessPoint, SigninAccessPoint.MAX);
+    }
+
     @VisibleForTesting
     @NativeMethods
     public interface Natives {