Commit a349c4f4 authored by Ramin Halavati's avatar Ramin Halavati Committed by Commit Bot

Remove Android specific preferences from incognito whitelist.

The following Android specific preferences are removed from the
persistent storage list for incognito mode.
 - kClickedUpdateMenuItem,
 - kContextualSearchEnabled,
 - kLatestVersionWhenClickedUpdateMenuItem,
 - kNotificationsVibrateEnabled
 - kPromptForDownloadAndroid
As these preferences are not written from inside an incognito window,
the CL is not expected to make any behavioral change and is just
cleanup.

Bug: 861722
Change-Id: Idb73eb2fc1e7c7c49faf0c92b17aad3b22c4fa9e
Reviewed-on: https://chromium-review.googlesource.com/1189922
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: default avatarTheresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587018}
parent fc352292
...@@ -196,9 +196,6 @@ const char* const kTemporaryIncognitoWhitelist[] = { ...@@ -196,9 +196,6 @@ const char* const kTemporaryIncognitoWhitelist[] = {
#endif #endif
prefs::kDataSaverEnabled, prefs::kSSLErrorOverrideAllowed, prefs::kDataSaverEnabled, prefs::kSSLErrorOverrideAllowed,
#if defined(OS_ANDROID)
prefs::kContextualSearchEnabled,
#endif // defined(OS_ANDROID)
#if defined(OS_MACOSX) || defined(OS_WIN) || \ #if defined(OS_MACOSX) || defined(OS_WIN) || \
(defined(OS_LINUX) && !defined(OS_CHROMEOS)) (defined(OS_LINUX) && !defined(OS_CHROMEOS))
prefs::kConfirmToQuitEnabled, prefs::kConfirmToQuitEnabled,
...@@ -298,7 +295,6 @@ const char* const kTemporaryIncognitoWhitelist[] = { ...@@ -298,7 +295,6 @@ const char* const kTemporaryIncognitoWhitelist[] = {
prefs::kLocalDiscoveryNotificationsEnabled, prefs::kLocalDiscoveryNotificationsEnabled,
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
prefs::kNotificationsVibrateEnabled,
prefs::kMigratedToSiteNotificationChannels, prefs::kMigratedToSiteNotificationChannels,
prefs::kClearedBlockedSiteNotificationChannels, prefs::kClearedBlockedSiteNotificationChannels,
#endif #endif
...@@ -344,7 +340,7 @@ const char* const kTemporaryIncognitoWhitelist[] = { ...@@ -344,7 +340,7 @@ const char* const kTemporaryIncognitoWhitelist[] = {
prefs::kOpenPdfDownloadInSystemReader, prefs::kOpenPdfDownloadInSystemReader,
#endif #endif
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
prefs::kPromptForDownloadAndroid, prefs::kShowMissingSdCardErrorAndroid, prefs::kShowMissingSdCardErrorAndroid,
#endif #endif
// prefs::kSaveFileDefaultDirectory, prefs::kSaveFileType, // prefs::kSaveFileDefaultDirectory, prefs::kSaveFileType,
...@@ -515,11 +511,6 @@ const char* const kTemporaryIncognitoWhitelist[] = { ...@@ -515,11 +511,6 @@ const char* const kTemporaryIncognitoWhitelist[] = {
prefs::kAllowDinosaurEasterEgg, prefs::kAllowDinosaurEasterEgg,
#if defined(OS_ANDROID)
prefs::kClickedUpdateMenuItem,
prefs::kLatestVersionWhenClickedUpdateMenuItem,
#endif
prefs::kOriginTrialPublicKey, prefs::kOriginTrialDisabledFeatures, prefs::kOriginTrialPublicKey, prefs::kOriginTrialDisabledFeatures,
prefs::kOriginTrialDisabledTokens, prefs::kOriginTrialDisabledTokens,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment