Commit a36ae47a authored by Angela Yoeurng's avatar Angela Yoeurng Committed by Commit Bot

[omnibox] Hide keyword hint if suggestion button row is enabled

Bug: 1046523
Change-Id: Ie25435820d7ebbb67b884638fd4add05a7011c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341840Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
Reviewed-by: default avatarOrin Jaworski <orinj@chromium.org>
Commit-Queue: Angela Yoeurng <yoangela@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796072}
parent fc9217ef
...@@ -576,8 +576,10 @@ void LocationBarView::Layout() { ...@@ -576,8 +576,10 @@ void LocationBarView::Layout() {
} }
// Because IMEs may eat the tab key, we don't show "press tab to search" while // Because IMEs may eat the tab key, we don't show "press tab to search" while
// IME composition is in progress. // IME composition is in progress.
if (HasFocus() && !keyword.empty() && // The keyword hint is also not shown when the Button Row is enabled since
omnibox_view_->model()->is_keyword_hint() && // it's now redundant with the keyword button and is no longer accurate.
if (!OmniboxFieldTrial::IsSuggestionButtonRowEnabled() && HasFocus() &&
!keyword.empty() && omnibox_view_->model()->is_keyword_hint() &&
!omnibox_view_->IsImeComposing()) { !omnibox_view_->IsImeComposing()) {
trailing_decorations.AddDecoration(vertical_padding, location_height, true, trailing_decorations.AddDecoration(vertical_padding, location_height, true,
0, edge_padding, keyword_hint_view_); 0, edge_padding, keyword_hint_view_);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment