Commit a3874ecb authored by timloh's avatar timloh Committed by Commit bot

Remove unused HasUserGestureRequest and unneeded request_url_ in PermissionRequestManager

Review-Url: https://codereview.chromium.org/2856413002
Cr-Commit-Position: refs/heads/master@{#469269}
parent a26e3d4f
......@@ -113,7 +113,7 @@ void PermissionRequestManager::AddRequest(PermissionRequest* request) {
// any other renderer-side nav initiations?). Double-check this for
// correct behavior on interstitials -- we probably want to basically queue
// any request for which GetVisibleURL != GetLastCommittedURL.
request_url_ = web_contents()->GetLastCommittedURL();
const GURL& request_url_ = web_contents()->GetLastCommittedURL();
bool is_main_frame = url::Origin(request_url_)
.IsSameOriginWith(url::Origin(request->GetOrigin()));
......@@ -420,8 +420,6 @@ void PermissionRequestManager::FinalizeBubble() {
accept_states_.clear();
if (queued_requests_.size() || queued_frame_requests_.size())
TriggerShowBubble();
else
request_url_ = GURL();
}
void PermissionRequestManager::CancelPendingQueues() {
......
......@@ -163,10 +163,6 @@ class PermissionRequestManager
// request may or may not be the same object as |request|.
PermissionRequest* GetExistingRequest(PermissionRequest* request);
// Returns true if |queue| contains a request which was generated by a user
// gesture. Returns false otherwise.
bool HasUserGestureRequest(const std::vector<PermissionRequest*>& queue);
// Calls PermissionGranted on a request and all its duplicates.
void PermissionGrantedIncludingDuplicates(PermissionRequest* request);
// Calls PermissionDenied on a request and all its duplicates.
......@@ -194,9 +190,6 @@ class PermissionRequestManager
std::unordered_multimap<PermissionRequest*, PermissionRequest*>
duplicate_requests_;
// URL of the main frame in the WebContents to which this manager is attached.
// TODO(gbillock): if there are iframes in the page, we need to deal with it.
GURL request_url_;
bool main_frame_has_fully_loaded_;
// Whether the response to each request should be persisted.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment