Revert "WebUI: Stop auto-generating Polymer 3 version of cr-splitter."

This reverts commit 4af59255.

Reason for revert: broken linux-archive-rel build

Build error is 

Build failure is: ENOENT: no such file or directory, open '/b/s/w/ir/cache/builder/src/out/Release/gen/ui/webui/resources/cr_elements/cr_splitter/cr_splitter.m.js'

Build is here:
https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/19235

Original change's description:
> WebUI: Stop auto-generating Polymer 3 version of cr-splitter.
> 
> The Polymer 2 version is not used anymore, therefore no auto-generation
> is necessary and the v3 version can be directly checked in.
> 
> Fixed: 1042545
> Change-Id: I5054477c0b7427f4ec6b760e5da3eac904af2320
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003114
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732590}

TBR=dpapad@chromium.org,rbpotter@chromium.org

Change-Id: I363a778967e7be5fafc11fb1a72cebdd5c8dac16
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006214Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732596}

chrome/browser/resources/bookmarks/BUILD.gn

@@ -29,7 +29,9 @@ if (optimize_webui) {
     pak_file = bookmarks_pak_file
     out_folder = unpak_folder
 
-    deps = [ ":flattened_resources" ]
+    deps = [
+      ":flattened_resources",
+    ]
   }
 
   grit("flattened_resources") {
@@ -42,7 +44,9 @@ if (optimize_webui) {
       "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir),
     ]
 
-    deps = [ ":polymer3_elements" ]
+    deps = [
+      ":polymer3_elements",
+    ]
     defines = chrome_grit_defines
     outputs = [
       "grit/bookmarks_resources.h",
@@ -189,7 +193,7 @@ js_library("app") {
     ":store",
     ":store_client",
     "//third_party/polymer/v3_0/components-chromium/polymer:polymer_bundled",
-    "//ui/webui/resources/cr_elements/cr_splitter:cr_splitter",
+    "//ui/webui/resources/cr_elements/cr_splitter:cr_splitter.m",
     "//ui/webui/resources/js:find_shortcut_behavior.m",
     "//ui/webui/resources/js:load_time_data.m",
   ]
@@ -236,7 +240,9 @@ js_library("debouncer") {
 }
 
 js_library("dialog_focus_manager") {
-  deps = [ "//ui/webui/resources/js:cr.m" ]
+  deps = [
+    "//ui/webui/resources/js:cr.m",
+  ]
 }
 
 js_library("dnd_manager") {
@@ -375,11 +381,15 @@ js_library("toolbar") {
 }
 
 js_library("types") {
-  deps = [ ":constants" ]
+  deps = [
+    ":constants",
+  ]
   externs_list = [ "$externs_path/chrome_extensions.js" ]
 }
 
 js_library("util") {
-  deps = [ ":types" ]
+  deps = [
+    ":types",
+  ]
   externs_list = [ "$externs_path/chrome_extensions.js" ]
 }

chrome/browser/resources/print_preview/data/model.js

@@ -6,7 +6,7 @@ import {assert} from 'chrome://resources/js/assert.m.js';
 import {isMac, isWindows} from 'chrome://resources/js/cr.m.js';
 import {loadTimeData} from 'chrome://resources/js/load_time_data.m.js';
 import {PromiseResolver} from 'chrome://resources/js/promise_resolver.m.js';
-import {Polymer} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js';
+import {html, Polymer} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js';
 
 import {BackgroundGraphicsModeRestriction, Policies} from '../native_layer.js';
 

chrome/test/data/webui/cr_elements/BUILD.gn

@@ -22,6 +22,7 @@ js_modulizer("modulize") {
     "cr_radio_button_test.js",
     "cr_radio_group_test.js",
     "cr_search_field_tests.js",
+    "cr_splitter_test.js",
     "cr_toolbar_search_field_tests.js",
     "cr_tabs_test.js",
     "cr_toast_test.js",

chrome/test/data/webui/cr_elements/cr_elements_browsertest.js

@@ -400,6 +400,28 @@ TEST_F('CrElementsSliderTest', 'All', function() {
   mocha.run();
 });
 
+/**
+ * @constructor
+ * @extends {CrElementsBrowserTest}
+ */
+function CrElementsSplitterTest() {}
+
+CrElementsSplitterTest.prototype = {
+  __proto__: CrElementsBrowserTest.prototype,
+
+  /** @override */
+  browsePreload: 'chrome://resources/cr_elements/cr_splitter/cr_splitter.html',
+
+  /** @override */
+  extraLibraries: CrElementsBrowserTest.prototype.extraLibraries.concat([
+    'cr_splitter_test.js',
+  ]),
+};
+
+TEST_F('CrElementsSplitterTest', 'All', function() {
+  mocha.run();
+});
+
 /**
  * @constructor
  * @extends {CrElementsBrowserTest}

chrome/test/data/webui/cr_elements/cr_elements_v3_browsertest.js

@@ -188,7 +188,7 @@ GEN('#endif');
 var CrElementsSplitterV3Test = class extends CrElementsV3BrowserTest {
   /** @override */
   get browsePreload() {
-    return 'chrome://test?module=cr_elements/cr_splitter_test.js';
+    return 'chrome://test?module=cr_elements/cr_splitter_test.m.js';
   }
 };
 

chrome/test/data/webui/cr_elements/cr_splitter_test.js

@@ -2,7 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import 'chrome://resources/cr_elements/cr_splitter/cr_splitter.js';
+// clang-format off
+// #import 'chrome://resources/cr_elements/cr_splitter/cr_splitter.m.js';
+// clang-format on
 
 suite('cr-splitter', function() {
   let crSplitter;

ui/webui/resources/cr_elements/BUILD.gn

@@ -46,6 +46,7 @@ group("closure_compile") {
     "cr_radio_button:closure_compile_module",
     "cr_radio_group:closure_compile_module",
     "cr_search_field:closure_compile_module",
+    "cr_splitter:closure_compile_module",
     "cr_tabs:closure_compile_module",
     "cr_toast:closure_compile_module",
     "cr_toggle:closure_compile_module",
@@ -74,11 +75,15 @@ js_type_check("cr_elements_resources") {
 }
 
 js_library("cr_scrollable_behavior") {
-  deps = [ "//third_party/polymer/v1_0/components-chromium/iron-list:iron-list-extracted" ]
+  deps = [
+    "//third_party/polymer/v1_0/components-chromium/iron-list:iron-list-extracted",
+  ]
 }
 
 js_library("cr_container_shadow_behavior") {
-  deps = [ "//ui/webui/resources/js:assert" ]
+  deps = [
+    "//ui/webui/resources/js:assert",
+  ]
 }
 
 # Targets for auto-generating Polymer 3 JS Modules.
@@ -171,6 +176,7 @@ group("polymer3_elements") {
     "cr_radio_group:cr_radio_group_module",
     "cr_search_field:cr_search_field_module",
     "cr_search_field:modulize",
+    "cr_splitter:cr_splitter_module",
     "cr_tabs:cr_tabs_module",
     "cr_toast:cr_toast_manager_module",
     "cr_toast:cr_toast_module",
@@ -193,11 +199,17 @@ group("polymer3_elements") {
 
 js_type_check("cr_elements_module_resources") {
   uses_js_modules = true
-  deps = [ ":cr_container_shadow_behavior.m" ]
+  deps = [
+    ":cr_container_shadow_behavior.m",
+  ]
 }
 
 js_library("cr_container_shadow_behavior.m") {
-  sources = [ "$root_gen_dir/ui/webui/resources/cr_elements/cr_container_shadow_behavior.m.js" ]
-  deps = [ "//ui/webui/resources/js:assert.m" ]
+  sources = [
+    "$root_gen_dir/ui/webui/resources/cr_elements/cr_container_shadow_behavior.m.js",
+  ]
+  deps = [
+    "//ui/webui/resources/js:assert.m",
+  ]
   extra_deps = [ ":modulize" ]
 }

ui/webui/resources/cr_elements/cr_splitter/BUILD.gn

@@ -3,14 +3,36 @@
 # found in the LICENSE file.
 
 import("//third_party/closure_compiler/compile_js.gni")
+import("//tools/polymer/polymer.gni")
 
 js_type_check("closure_compile") {
-  is_polymer3 = true
-  deps = [ ":cr_splitter" ]
+  deps = [
+    ":cr_splitter",
+  ]
 }
 
 js_library("cr_splitter") {
+}
+
+polymer_modulizer("cr_splitter") {
+  js_file = "cr_splitter.js"
+  html_file = "cr_splitter.html"
+  html_type = "dom-module"
+}
+
+js_type_check("closure_compile_module") {
+  is_polymer3 = true
+  deps = [
+    ":cr_splitter.m",
+  ]
+}
+
+js_library("cr_splitter.m") {
+  sources = [
+    "$root_gen_dir/ui/webui/resources/cr_elements/cr_splitter/cr_splitter.m.js",
+  ]
   deps = [
     "//third_party/polymer/v3_0/components-chromium/polymer:polymer_bundled",
   ]
+  extra_deps = [ ":cr_splitter_module" ]
 }

ui/webui/resources/cr_elements/cr_splitter/cr_splitter.html

+<link rel="import" href="../../html/polymer.html">
+
+<dom-module id="cr-splitter">
+  <template>
+  </template>
+  <script src="cr_splitter.js"></script>
+</dom-module>

ui/webui/resources/cr_elements/cr_splitter/cr_splitter.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {Polymer} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js';
+(function() {
 
 // TODO(arv): Currently this only supports horizontal layout.
 // TODO(arv): This ignores min-width and max-width of the elements to the
@@ -40,8 +40,6 @@ function getZoomFactor(doc) {
 Polymer({
   is: 'cr-splitter',
 
-  _template: null,
-
   properties: {
     resizeNextElement: {
       type: Boolean,
@@ -268,3 +266,4 @@ Polymer({
     this.classList.remove('splitter-active');
   },
 });
+})();

ui/webui/resources/cr_elements_resources.grdp

@@ -154,6 +154,14 @@
              file="cr_elements/cr_slider/cr_slider.js"
              type="chrome_html"
              compress="gzip" />
+  <structure name="IDR_CR_ELEMENTS_CR_SPLITTER_HTML"
+             file="cr_elements/cr_splitter/cr_splitter.html"
+             type="chrome_html"
+             compress="gzip" />
+  <structure name="IDR_CR_ELEMENTS_CR_SPLITTER_JS"
+             file="cr_elements/cr_splitter/cr_splitter.js"
+             type="chrome_html"
+             compress="gzip" />
   <if expr="chromeos">
     <structure name="IDR_CR_ELEMENTS_CR_SEARCHABLE_DROP_DOWN_HTML"
                file="cr_elements/cr_searchable_drop_down/cr_searchable_drop_down.html"

ui/webui/resources/cr_elements_resources_v3.grdp

@@ -116,8 +116,9 @@
          use_base_dir="false"
          type="BINDATA"
          compress="gzip" />
-  <include name="IDR_CR_ELEMENTS_CR_SPLITTER_JS"
-         file="cr_elements/cr_splitter/cr_splitter.js"
+  <include name="IDR_CR_ELEMENTS_CR_SPLITTER_M_JS"
+         file="${root_gen_dir}/ui/webui/resources/cr_elements/cr_splitter/cr_splitter.m.js"
+         use_base_dir="false"
          type="BINDATA"
          compress="gzip" />
   <include name="IDR_CR_ELEMENTS_CR_TABS_M_JS"