Add chrome/browser/ui to the GN build.

This moves the intermediate grit files:
ui/ui_resources -> ui/resources
ui/ui_strings -> ui/strings
in the GYP build to put it in line with the GN one (and also what one would expect).

R=ajwong@chromium.org
BUG=

Review URL: https://codereview.chromium.org/381113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282663 0039d316-1c4b-4281-b951-d872f2087c98

BUILD.gn

@@ -20,7 +20,9 @@ group("root") {
     #"//base(//build/toolchain/nacl:x86_newlib)",
 
     "//cc",
+    "//chrome/browser",
     "//chrome/browser/devtools",
+    "//chrome/browser/ui",
     "//chrome/browser/ui/views",
     "//chrome/common",
     "//chrome/plugin",
@@ -140,7 +142,9 @@ group("root") {
   if (is_android) {
     deps -= [
       "//cc",
+      "//chrome/browser",  # Blocked on content.
       "//chrome/browser/devtools",  # Blocked on content.
+      "//chrome/browser/ui",  # Blocked on content.
       "//chrome/browser/ui/views",  # Blocked on content.
       "//chrome/common",  # Blocked on content.
       "//chrome/plugin",  # Blocked on content.

android_webview/android_webview.gyp

@@ -74,7 +74,7 @@
             'pak_inputs': [
               '<(SHARED_INTERMEDIATE_DIR)/content/content_resources.pak',
               '<(SHARED_INTERMEDIATE_DIR)/net/net_resources.pak',
-              '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_resources_100_percent.pak',
+              '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_resources_100_percent.pak',
               '<(SHARED_INTERMEDIATE_DIR)/webkit/blink_resources.pak',
               '<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_resources_100_percent.pak',
             ],
@@ -115,7 +115,7 @@
       'include_dirs': [
         '..',
         '../skia/config',
-        '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/',
+        '<(SHARED_INTERMEDIATE_DIR)/ui/resources/',
       ],
       'sources': [
         'browser/aw_browser_context.cc',

apps/shell/app_shell.gyp

@@ -55,8 +55,8 @@
               '<(SHARED_INTERMEDIATE_DIR)/extensions/extensions_resources.pak',
               '<(SHARED_INTERMEDIATE_DIR)/extensions/strings/extensions_strings_en-US.pak',
               '<(SHARED_INTERMEDIATE_DIR)/ui/app_locale_settings/app_locale_settings_en-US.pak',
-              '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_resources_100_percent.pak',
-              '<(SHARED_INTERMEDIATE_DIR)/ui/ui_strings/ui_strings_en-US.pak',
+              '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_resources_100_percent.pak',
+              '<(SHARED_INTERMEDIATE_DIR)/ui/strings/ui_strings_en-US.pak',
               '<(SHARED_INTERMEDIATE_DIR)/webkit/devtools_resources.pak',
             ],
             'pak_output': '<(PRODUCT_DIR)/app_shell.pak',

ash/BUILD.gn

+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# TODO(GYP) this is a placeholder so that targets that depend on ash can get
+# the resources generated.
+group("ash") {
+  deps = [
+    "//ash/resources",
+    "//ash/strings",
+  ]
+}

ash/ash.gyp

@@ -1058,7 +1058,7 @@
             ['exclude', 'autoclick/autoclick_unittest.cc'],
           ],
           'sources': [
-            '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_unscaled_resources.rc',
+            '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_unscaled_resources.rc',
           ],
           # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
           'msvs_disabled_warnings': [ 4267, ],

ash/ash_strings.gyp

@@ -5,6 +5,7 @@
 {
   'targets': [
     {
+      # GN version: //ash/strings
       'target_name': 'ash_strings',
       'type': 'none',
       'variables': {

ash/resources/BUILD.gn

+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//tools/grit/grit_rule.gni")
+
+grit("resources") {
+  source = "ash_resources.grd"
+}

ash/strings/BUILD.gn

+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//tools/grit/grit_rule.gni")
+
+grit("strings") {
+  source = "../ash_strings.grd"
+}

build/config/BUILD.gn

@@ -31,7 +31,6 @@ config("feature_flags") {
   # TODO(brettw) most of these need to be parameterized.
   defines = [
       "CHROMIUM_BUILD",
-      "ENABLE_ONE_CLICK_SIGNIN",
       "ENABLE_NOTIFICATIONS",
       "ENABLE_EGLIMAGE=1",
       "ENABLE_BACKGROUND=1",
@@ -180,6 +179,9 @@ config("feature_flags") {
   if (enable_google_now) {
     defines += [ "ENABLE_GOOGLE_NOW=1" ]
   }
+  if (enable_one_click_signin) {
+    defines += [ "ENABLE_ONE_CLICK_SIGNIN" ]
+  }
 }
 
 # Debug/release ----------------------------------------------------------------

build/config/features.gni

@@ -23,6 +23,12 @@ declare_args() {
 
   # Enables Native Client support.
   enable_nacl = (!is_ios && !is_android)
+
+  # If debug_devtools is set to true, JavaScript files for DevTools are stored
+  # as is and loaded from disk. Otherwise, a concatenated file is stored in
+  # resources.pak. It is still possible to load JS files from disk by passing
+  # --debug-devtools cmdline switch.
+  debug_devtools = false
 }
 
 # Additional dependent variables -----------------------------------------------
@@ -144,3 +150,9 @@ enable_image_loader_extension = is_chromeos
 enable_remoting = !is_ios && !is_android
 
 enable_google_now = !is_ios && !is_android
+
+enable_one_click_signin = is_win || is_mac || (is_linux && !is_chromeos)
+
+# Chrome OS: whether to also build the upcoming version of
+# ChromeVox, which can then be enabled via a command-line switch.
+enable_chromevox_next = false

build/config/ui.gni

@@ -14,7 +14,7 @@
 declare_args() {
   # Indicates if Ash is enabled. Ash is the Aura Shell which provides a
   # desktop-like environment for Aura. Requires use_aura = true
-  use_ash = is_win || is_chromeos
+  use_ash = is_win || is_linux
 
   # Indicates if Ozone is enabled. Ozone is a low-level library layer for Linux
   # that does not require X11.
@@ -25,7 +25,7 @@ declare_args() {
 
   # Indicates if Aura is enabled. Aura is a low-level windowing library, sort
   # of a replacement for GDI or GTK.
-  use_aura = is_linux || use_ozone || is_win || is_chromeos || use_ash
+  use_aura = is_win || is_linux
 
   # XInput2 multitouch support. Zero means disabled, nonzero indicates the
   # minimum XI2 version. For example, use_xi2_mt=2 means XI2.2 or above.

build/ui_resources_location.gypi

@@ -6,6 +6,6 @@
      # Two facilitate the two-sided patch, this variable indicates the
      # one currently in use.
      # TODO(brettw) remove this when the move is complete.
-     'ui_resources_gen_subdir': 'ui_resources',
+     'ui_resources_gen_subdir': 'resources',
   },
 }

chrome/BUILD.gn

@@ -31,6 +31,24 @@ group("extra_resources") {
     "//chrome/browser/resources:sync_internals_resources",
     "//chrome/browser/resources:translate_internals_resources",
   ]
+  if (!is_ios) {
+    deps += [
+      "//chrome/browser/resources:component_extension_resources",
+      "//chrome/browser/resources:options_resources",
+      "//chrome/browser/resources:quota_internals_resources",
+      "//chrome/browser/resources:sync_file_system_internals_resources",
+    ]
+  }
+
+  if (enable_chromevox_next) {
+    deps += [
+      #'browser/resources/chromeos/chromevox2/chromevox.gyp:chromevox2',  TODO(GYP)
+    ]
+  } else {
+    deps += [
+      #'browser/resources/chromeos/chromevox/chromevox.gyp:chromevox',  TODO(GYP)
+    ]
+  }
 }
 
 # GYP version: chrome/chrome_resources.gyp:chrome_strings

chrome/browser/BUILD.gn

@@ -121,7 +121,7 @@ static_library("browser") {
     #        # These files are generated by GRIT.
     #        '<(grit_out_dir)/grit/component_extension_resources_map.cc',
     #        '<(grit_out_dir)/grit/theme_resources_map.cc',
-    #        '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/grit/ui_resources_map.cc',
+    #        '<(SHARED_INTERMEDIATE_DIR)/ui/resources/grit/ui_resources_map.cc',
     #
     #        # This file is generated by
     #        # chrome/browser/metrics/variations/generate_resources_map.py

chrome/browser/resources/BUILD.gn

@@ -32,3 +32,26 @@ grit("translate_internals_resources") {
   source = "translate_internals_resources.grd"
 }
 
+# GYP version: copy command of chrome_extra_resources
+copy("extension_resource_demo") {
+  sources = [ "extension_resource/demo/library.js" ]
+  outputs = [ "$root_out_dir/resources/extension/demo/library.js" ]
+}
+
+if (!is_ios) {
+  grit("component_extension_resources") {
+    source = "component_extension_resources.grd"
+  }
+
+  grit("options_resources") {
+    source = "options_resources.grd"
+  }
+
+  grit("quota_internals_resources") {
+    source = "quota_internals_resources.grd"
+  }
+
+  grit("sync_file_system_internals_resources") {
+    source = "sync_file_system_internals_resources.grd"
+  }
+}

chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_ui.cc

@@ -13,7 +13,7 @@
 #include "content/public/browser/web_ui.h"
 #include "content/public/browser/web_ui_data_source.h"
 #include "grit/sync_file_system_internals_resources.h"
-#include "ui/ui_resources/grit/ui_resources.h"
+#include "ui/resources/grit/ui_resources.h"
 
 namespace {
 

chrome/chrome_browser.gypi

@@ -2974,7 +2974,7 @@
             # These files are generated by GRIT.
             '<(grit_out_dir)/grit/component_extension_resources_map.cc',
             '<(grit_out_dir)/grit/theme_resources_map.cc',
-            '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/grit/ui_resources_map.cc',
+            '<(SHARED_INTERMEDIATE_DIR)/ui/resources/grit/ui_resources_map.cc',
 
             # This file is generated by
             # chrome/browser/metrics/variations/generate_resources_map.py

chrome/chrome_browser_ui.gypi

@@ -783,8 +783,6 @@
       'browser/ui/global_error/global_error_service_factory.h',
       'browser/ui/host_desktop.cc',
       'browser/ui/host_desktop.h',
-      'browser/ui/hung_plugin_tab_helper.cc',
-      'browser/ui/hung_plugin_tab_helper.h',
       'browser/ui/login/login_interstitial_delegate.cc',
       'browser/ui/login/login_interstitial_delegate.h',
       'browser/ui/login/login_prompt.cc',
@@ -1061,8 +1059,6 @@
       'browser/ui/webui/invalidations_message_handler.h',
       'browser/ui/webui/invalidations_ui.cc',
       'browser/ui/webui/invalidations_ui.h',
-      'browser/ui/webui/media/webrtc_logs_ui.cc',
-      'browser/ui/webui/media/webrtc_logs_ui.h',
       'browser/ui/webui/memory_internals/memory_internals_handler.cc',
       'browser/ui/webui/memory_internals/memory_internals_handler.h',
       'browser/ui/webui/memory_internals/memory_internals_proxy.cc',
@@ -1124,7 +1120,6 @@
       'browser/ui/zoom/zoom_event_manager.cc',
       'browser/ui/zoom/zoom_event_manager.h',
       'browser/ui/zoom/zoom_observer.h',
-      '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/ui/webui/omnibox/omnibox.mojom.cc',
     ],
     # Note that we assume app list is enabled on all views builds, so the
     # views-specific app list files are in the views section.
@@ -2017,16 +2012,10 @@
       'browser/ui/views/find_bar_view.h',
       'browser/ui/views/first_run_bubble.cc',
       'browser/ui/views/first_run_bubble.h',
-      'browser/ui/views/frame/browser_frame_ash.cc',
-      'browser/ui/views/frame/browser_frame_ash.h',
       'browser/ui/views/frame/browser_frame.cc',
       'browser/ui/views/frame/browser_frame_common_win.cc',
       'browser/ui/views/frame/browser_frame_common_win.h',
       'browser/ui/views/frame/browser_frame.h',
-      'browser/ui/views/frame/browser_header_painter_ash.cc',
-      'browser/ui/views/frame/browser_header_painter_ash.h',
-      'browser/ui/views/frame/browser_non_client_frame_view_ash.cc',
-      'browser/ui/views/frame/browser_non_client_frame_view_ash.h',
       'browser/ui/views/frame/browser_non_client_frame_view.cc',
       'browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc',
       'browser/ui/views/frame/browser_non_client_frame_view.h',
@@ -2045,8 +2034,6 @@
       'browser/ui/views/frame/contents_layout_manager.h',
       'browser/ui/views/frame/contents_web_view.cc',
       'browser/ui/views/frame/contents_web_view.h',
-      'browser/ui/views/frame/immersive_mode_controller_ash.cc',
-      'browser/ui/views/frame/immersive_mode_controller_ash.h',
       'browser/ui/views/frame/immersive_mode_controller.cc',
       'browser/ui/views/frame/immersive_mode_controller_factory.cc',
       'browser/ui/views/frame/immersive_mode_controller.h',
@@ -2055,10 +2042,8 @@
       'browser/ui/views/frame/minimize_button_metrics_win.cc',
       'browser/ui/views/frame/minimize_button_metrics_win.h',
       'browser/ui/views/frame/native_browser_frame_factory.cc',
-      'browser/ui/views/frame/native_browser_frame_factory.cc',
-      'browser/ui/views/frame/native_browser_frame_factory_chromeos.cc',
-      'browser/ui/views/frame/native_browser_frame_factory.h',
       'browser/ui/views/frame/native_browser_frame_factory.h',
+      'browser/ui/views/frame/native_browser_frame_factory_chromeos.cc',
       'browser/ui/views/frame/native_browser_frame.h',
       'browser/ui/views/frame/opaque_browser_frame_view_layout.cc',
       'browser/ui/views/frame/opaque_browser_frame_view_layout_delegate.h',
@@ -2067,8 +2052,6 @@
       'browser/ui/views/frame/opaque_browser_frame_view_linux.h',
       'browser/ui/views/frame/opaque_browser_frame_view_platform_specific.cc',
       'browser/ui/views/frame/opaque_browser_frame_view_platform_specific.h',
-      'browser/ui/views/frame/scroll_end_effect_controller_ash.cc',
-      'browser/ui/views/frame/scroll_end_effect_controller_ash.h',
       'browser/ui/views/frame/scroll_end_effect_controller.h',
       'browser/ui/views/frame/system_menu_insertion_delegate_win.cc',
       'browser/ui/views/frame/system_menu_insertion_delegate_win.h',
@@ -2246,11 +2229,9 @@
       'browser/ui/views/tabs/tab_strip.cc',
       'browser/ui/views/tabs/tab_strip_controller.h',
       'browser/ui/views/tabs/tab_strip.h',
-      'browser/ui/views/tabs/window_finder_ash.cc',
       'browser/ui/views/tabs/window_finder_chromeos.cc',
       'browser/ui/views/tabs/window_finder.h',
       'browser/ui/views/tabs/window_finder_win.cc',
-      'browser/ui/views/task_manager_view.cc',
       'browser/ui/views/theme_image_mapper_chromeos.cc',
       'browser/ui/views/theme_image_mapper_desktop.cc',
       'browser/ui/views/theme_image_mapper.h',
@@ -2381,8 +2362,6 @@
       'browser/ui/ash/launcher/browser_status_monitor.h',
       'browser/ui/ash/launcher/chrome_launcher_app_menu_item.cc',
       'browser/ui/ash/launcher/chrome_launcher_app_menu_item.h',
-      'browser/ui/bookmarks/bookmark_tab_helper_delegate.cc',
-      'browser/ui/bookmarks/bookmark_tab_helper_delegate.h',
       'browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.cc',
       'browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h',
       'browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc',
@@ -2449,6 +2428,20 @@
     'chrome_browser_ui_non_ash_sources': [
       'browser/ui/views/touch_uma/touch_uma.cc',
     ],
+    # Ash + Views.
+    'chrome_browser_ui_ash_views_sources': [
+      'browser/ui/views/frame/browser_frame_ash.cc',
+      'browser/ui/views/frame/browser_frame_ash.h',
+      'browser/ui/views/frame/browser_header_painter_ash.cc',
+      'browser/ui/views/frame/browser_header_painter_ash.h',
+      'browser/ui/views/frame/browser_non_client_frame_view_ash.cc',
+      'browser/ui/views/frame/browser_non_client_frame_view_ash.h',
+      'browser/ui/views/frame/immersive_mode_controller_ash.cc',
+      'browser/ui/views/frame/immersive_mode_controller_ash.h',
+      'browser/ui/views/frame/scroll_end_effect_controller_ash.cc',
+      'browser/ui/views/frame/scroll_end_effect_controller_ash.h',
+      'browser/ui/views/tabs/window_finder_ash.cc',
+    ],
     # Used when Ash is enabled but not ChromeOS.
     'chrome_browser_ui_ash_non_chromeos': [
       'browser/ui/ash/chrome_shell_delegate_views.cc',
@@ -2595,7 +2588,10 @@
       ],
       'conditions': [
         ['OS != "ios"', {
-          'sources': [ '<@(chrome_browser_ui_non_ios_sources)' ],
+          'sources': [
+            '<@(chrome_browser_ui_non_ios_sources)',
+            '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/ui/webui/omnibox/omnibox.mojom.cc',
+          ],
           'dependencies': [
             'browser_extensions',
             'browser/performance_monitor/performance_monitor.gyp:performance_monitor',
@@ -2716,6 +2712,9 @@
             ['chromeos == 0', {
               'sources': [ '<@(chrome_browser_ui_views_non_chromeos_sources)' ],
             }],
+            ['use_ash == 1', {
+              'sources': [ '<@(chrome_browser_ui_ash_views_sources)' ],
+            }],
           ],
         }],
         ['use_aura==1 and chromeos==0 and use_ozone==0 and OS=="linux"', {

chrome/chrome_dll.gypi

@@ -129,7 +129,7 @@
                 '../base/win/dllmain.cc',
 
                 # Cursors.
-                '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_unscaled_resources.rc',
+                '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_unscaled_resources.rc',
               ],
               'include_dirs': [
                 '<(DEPTH)/third_party/wtl/include',

chrome/chrome_repack_chrome_100_percent.gypi

@@ -6,7 +6,7 @@
   'variables': {
     'pak_inputs': [
       '<(SHARED_INTERMEDIATE_DIR)/components/component_resources_100_percent.pak',
-      '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_resources_100_percent.pak',
+      '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_resources_100_percent.pak',
       '<(grit_out_dir)/renderer_resources_100_percent.pak',
       '<(grit_out_dir)/theme_resources_100_percent.pak',
     ],

chrome/chrome_repack_chrome_200_percent.gypi

@@ -6,7 +6,7 @@
   'variables': {
     'pak_inputs': [
       '<(SHARED_INTERMEDIATE_DIR)/components/component_resources_200_percent.pak',
-      '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_resources_200_percent.pak',
+      '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_resources_200_percent.pak',
       '<(grit_out_dir)/renderer_resources_200_percent.pak',
       '<(grit_out_dir)/theme_resources_200_percent.pak',
     ],

chrome/chrome_repack_resources.gypi

@@ -8,7 +8,7 @@
       '<(SHARED_INTERMEDIATE_DIR)/chrome/chrome_unscaled_resources.pak',
       '<(SHARED_INTERMEDIATE_DIR)/components/component_resources.pak',
       '<(SHARED_INTERMEDIATE_DIR)/net/net_resources.pak',
-      '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/webui_resources.pak',
+      '<(SHARED_INTERMEDIATE_DIR)/ui/resources/webui_resources.pak',
       '<(grit_out_dir)/browser_resources.pak',
       '<(grit_out_dir)/common_resources.pak',
       '<(grit_out_dir)/invalidations_resources.pak',

chrome/chrome_resources.gyp

@@ -84,6 +84,7 @@
           ],
           'actions': [
             {
+              # GN version: //chrome/browser/resources:component_extension_resources
               'action_name': 'generate_component_extension_resources',
               'variables': {
                 'grit_grd_file': 'browser/resources/component_extension_resources.grd',
@@ -91,6 +92,7 @@
               'includes': [ '../build/grit_action.gypi' ],
             },
             {
+              # GN version: //chrome/browser/resources:options_resources
               'action_name': 'generate_options_resources',
               'variables': {
                 'grit_grd_file': 'browser/resources/options_resources.grd',
@@ -98,6 +100,7 @@
               'includes': [ '../build/grit_action.gypi' ],
             },
             {
+              # GN version: //chrome/browser/resources:quota_internals_resources
               'action_name': 'generate_quota_internals_resources',
               'variables': {
                 'grit_grd_file': 'browser/resources/quota_internals_resources.grd',
@@ -105,6 +108,7 @@
               'includes': [ '../build/grit_action.gypi' ],
             },
             {
+              # GN version: //chrome/browser/resources:sync_file_system_internals_resources
               'action_name': 'generate_sync_file_system_internals_resources',
               'variables': {
                 'grit_grd_file': 'browser/resources/sync_file_system_internals_resources.grd',
@@ -114,6 +118,7 @@
           ],
           'copies': [
             {
+              # GN version: //chrome/browser/resources:extension_resource_demo
               'destination': '<(PRODUCT_DIR)/resources/extension/demo',
               'files': [
                 'browser/resources/extension_resource/demo/library.js',

chrome/chrome_tests.gypi

@@ -340,7 +340,7 @@
             # but that causes errors in other targets when
             # resulting .res files get referenced multiple times.
             '<(SHARED_INTERMEDIATE_DIR)/chrome_version/other_version.rc',
-            '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_unscaled_resources.rc',
+            '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_unscaled_resources.rc',
 
             'browser/ui/views/accessibility/browser_views_accessibility_browsertest.cc',
           ],
@@ -1852,7 +1852,7 @@
         ['OS=="win"', {
           'sources': [
             '<(SHARED_INTERMEDIATE_DIR)/chrome_version/other_version.rc',
-            '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_unscaled_resources.rc',
+            '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_unscaled_resources.rc',
           ],
           'include_dirs': [
             '<(DEPTH)/third_party/wtl/include',
@@ -2174,7 +2174,7 @@
         ['OS=="win"', {
           'sources': [
             '<(SHARED_INTERMEDIATE_DIR)/chrome_version/other_version.rc',
-            '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_unscaled_resources.rc',
+            '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_unscaled_resources.rc',
           ],
           'include_dirs': [
             '<(DEPTH)/third_party/wtl/include',
@@ -2461,7 +2461,7 @@
         ['OS=="win"', {
           'sources': [
             '<(SHARED_INTERMEDIATE_DIR)/chrome_version/other_version.rc',
-            '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_unscaled_resources.rc',
+            '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_unscaled_resources.rc',
           ],
           'include_dirs': [
             '<(DEPTH)/third_party/wtl/include',

chrome/chrome_tests_unit.gypi

@@ -2529,7 +2529,7 @@
             # resulting .res files get referenced multiple times.
             '<(SHARED_INTERMEDIATE_DIR)/chrome_version/other_version.rc',
             '<(SHARED_INTERMEDIATE_DIR)/installer_util_strings/installer_util_strings.rc',
-            '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_unscaled_resources.rc',
+            '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_unscaled_resources.rc',
           ],
           'link_settings': {
             'libraries': [

chrome/tools/build/repack_locales.py

@@ -89,8 +89,8 @@ def calc_inputs(locale):
     inputs.append(os.path.join(SHARE_INT_DIR, 'webkit',
                   'webkit_strings_%s.pak' % locale))
 
-    #e.g. '<(SHARED_INTERMEDIATE_DIR)/ui/ui_strings_da.pak',
-    inputs.append(os.path.join(SHARE_INT_DIR, 'ui', 'ui_strings',
+    #e.g. '<(SHARED_INTERMEDIATE_DIR)/ui/strings_da.pak',
+    inputs.append(os.path.join(SHARE_INT_DIR, 'ui', 'strings',
                   'ui_strings_%s.pak' % locale))
 
     #e.g. '<(SHARED_INTERMEDIATE_DIR)/device/bluetooth/strings/

components/BUILD.gn

@@ -23,6 +23,7 @@ group("all_components") {
     "//components/domain_reliability",
     "//components/favicon_base",
     "//components/favicon/core",
+    "//components/feedback",
     "//components/history/core/browser",
     "//components/history/core/common",
     "//components/history/core/test",
@@ -80,6 +81,7 @@ group("all_components") {
       "//components/domain_reliability",  # Blocked on content.
       "//components/favicon_base",  # Should work, needs checking.
       "//components/favicon/core",  # Blocked on keyed service.
+      "//components/feedback",  # Blocked on content.
       "//components/history/core/browser",  # Should work, needs checking.
       "//components/history/core/common",  # Should work, needs checking.
       "//components/history/core/test",  # Should work, needs checking.

components/feedback.gypi

@@ -45,6 +45,7 @@
     },
     {
       # Protobuf compiler / generate rule for feedback
+      # GN version: //components/feedback/proto
       'target_name': 'feedback_proto',
       'type': 'static_library',
       'sources': [

components/feedback/BUILD.gn

+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+static_library("feedback") {
+  sources = [
+    "feedback_common.cc",
+    "feedback_common.h",
+    "feedback_data.cc",
+    "feedback_data.h",
+    "feedback_report.cc",
+    "feedback_report.h",
+    "feedback_switches.cc",
+    "feedback_switches.h",
+    "feedback_uploader.cc",
+    "feedback_uploader.h",
+    "feedback_uploader_chrome.cc",
+    "feedback_uploader_chrome.h",
+    "feedback_uploader_delegate.cc",
+    "feedback_uploader_delegate.h",
+    "feedback_uploader_factory.cc",
+    "feedback_uploader_factory.h",
+    "feedback_util.cc",
+    "feedback_util.h",
+    "tracing_manager.cc",
+    "tracing_manager.h",
+  ]
+
+  deps = [
+    "//base",
+    "//components/keyed_service/core:core",
+    "//components/feedback/proto",
+    "//content/public/common",
+    "//net",
+    "//third_party/zlib:zip",
+  ]
+}

components/feedback/proto/BUILD.gn

+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//third_party/protobuf/proto_library.gni")
+
+# GYP version: components/feedback.gypi:feedback_proto
+proto_library("proto") {
+  sources = [
+    "annotations.proto",
+    "chrome.proto",
+    "common.proto",
+    "dom.proto",
+    "extension.proto",
+    "math.proto",
+    "web.proto",
+  ]
+}

content/browser/BUILD.gn

@@ -80,7 +80,7 @@ source_set("browser") {
       "$root_gen_dir/webkit/grit/devtools_resources_map.cc",
       "$root_gen_dir/webkit/grit/devtools_resources_map.h",
       "$root_gen_dir/content/browser/tracing/grit/tracing_resources.h",
-      "$root_gen_dir/ui/ui_resources/grit/webui_resources_map.cc",
+      "$root_gen_dir/ui/resources/grit/webui_resources_map.cc",
       "$root_gen_dir/content/browser/devtools/devtools_protocol_constants.cc",
       "$root_gen_dir/content/browser/devtools/devtools_protocol_constants.h",
     ], ".")

content/content_browser.gypi

@@ -1327,7 +1327,7 @@
       '<(SHARED_INTERMEDIATE_DIR)/webkit/grit/devtools_resources_map.cc',
       '<(SHARED_INTERMEDIATE_DIR)/webkit/grit/devtools_resources_map.h',
       '<(SHARED_INTERMEDIATE_DIR)/content/browser/tracing/grit/tracing_resources.h',
-      '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/grit/webui_resources_map.cc',
+      '<(SHARED_INTERMEDIATE_DIR)/ui/resources/grit/webui_resources_map.cc',
       # These files are generated by devtools_protocol_constants_generator.py.
       '<(SHARED_INTERMEDIATE_DIR)/content/browser/devtools/devtools_protocol_constants.cc',
       '<(SHARED_INTERMEDIATE_DIR)/content/browser/devtools/devtools_protocol_constants.h',

content/content_shell.gypi

@@ -465,9 +465,9 @@
               '<(SHARED_INTERMEDIATE_DIR)/content/shell_resources.pak',
               '<(SHARED_INTERMEDIATE_DIR)/net/net_resources.pak',
               '<(SHARED_INTERMEDIATE_DIR)/ui/app_locale_settings/app_locale_settings_en-US.pak',
-              '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_resources_100_percent.pak',
-              '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/webui_resources.pak',
-              '<(SHARED_INTERMEDIATE_DIR)/ui/ui_strings/ui_strings_en-US.pak',
+              '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_resources_100_percent.pak',
+              '<(SHARED_INTERMEDIATE_DIR)/ui/resources/webui_resources.pak',
+              '<(SHARED_INTERMEDIATE_DIR)/ui/strings/ui_strings_en-US.pak',
               '<(SHARED_INTERMEDIATE_DIR)/webkit/blink_resources.pak',
               '<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_resources_100_percent.pak',
               '<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_strings_en-US.pak',

printing/BUILD.gn

@@ -2,6 +2,7 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//build/config/features.gni")
 import("//build/config/ui.gni")
 if (is_mac) {
   import("//build/config/mac/mac_sdk.gni")
@@ -10,8 +11,6 @@ if (is_android) {
   import("//build/config/android/rules.gni")
 }
 
-use_cups = ((is_linux && !is_chromeos) || is_mac)
-
 component("printing") {
   sources = [
     "backend/print_backend.cc",

ui/resources/ui_resources.gyp

@@ -9,7 +9,7 @@
       'target_name': 'ui_resources',
       'type': 'none',
       'variables': {
-        'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources',
+        'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/ui/resources',
       },
       'actions': [
         {
@@ -53,9 +53,9 @@
           'variables': {
             'pak_inputs': [
               '<(SHARED_INTERMEDIATE_DIR)/ui/app_locale_settings/app_locale_settings_en-US.pak',
-              '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_resources_100_percent.pak',
-              '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/webui_resources.pak',
-              '<(SHARED_INTERMEDIATE_DIR)/ui/ui_strings/ui_strings_en-US.pak',
+              '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_resources_100_percent.pak',
+              '<(SHARED_INTERMEDIATE_DIR)/ui/resources/webui_resources.pak',
+              '<(SHARED_INTERMEDIATE_DIR)/ui/strings/ui_strings_en-US.pak',
             ],
             'pak_output': '<(PRODUCT_DIR)/ui_test.pak',
           },
@@ -69,7 +69,7 @@
               # GN version //ui/resources:copy_ui_resources_100_percent
               'destination': '<(PRODUCT_DIR)/ui',
               'files': [
-                '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_resources_100_percent.pak',
+                '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_resources_100_percent.pak',
               ],
             },
           ],

ui/strings/ui_strings.gyp

@@ -16,7 +16,7 @@
           'action_name': 'ui_strings',
           'variables': {
             'grit_grd_file': 'ui_strings.grd',
-            'grit_out_dir': '<(grit_base_out_dir)/ui_strings',
+            'grit_out_dir': '<(grit_base_out_dir)/strings',
           },
           'includes': [ '../../build/grit_action.gypi' ],
         },
@@ -32,7 +32,7 @@
       'direct_dependent_settings': {
         'include_dirs': [
           '<(grit_base_out_dir)/app_locale_settings',
-          '<(grit_base_out_dir)/ui_strings',
+          '<(grit_base_out_dir)/strings',
         ],
       },
     },